[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7817: Fix the broker routing when segment is deleted

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #7817:
URL: https://github.com/apache/pinot/pull/7817#discussion_r755459241



##########
File path: pinot-broker/src/main/java/org/apache/pinot/broker/routing/RoutingManager.java
##########
@@ -110,94 +110,99 @@ public void init(HelixManager helixManager) {
   }
 
   @Override
-  public synchronized void processClusterChange(HelixConstants.ChangeType changeType) {
-    Preconditions.checkState(changeType == HelixConstants.ChangeType.EXTERNAL_VIEW
-        || changeType == HelixConstants.ChangeType.INSTANCE_CONFIG, "Illegal change type: %s", changeType);
-    if (changeType == HelixConstants.ChangeType.EXTERNAL_VIEW) {
-      processExternalViewChange();
-    } else {
+  public synchronized void processClusterChange(ChangeType changeType) {
+    if (changeType == ChangeType.IDEAL_STATE || changeType == ChangeType.EXTERNAL_VIEW) {

Review comment:
       Segment assignment is for the rebalancing, not for the routing callback updates. Routing updates are much cheaper. Broker will update the mapping from servers to segments on both IS and EV changes. IS change is less frequent than EV change, and we cache the version of them so we won't redo the work if the change is already processed, so I don't worry too much about the overhead.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org