You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/08/20 12:34:57 UTC

[GitHub] [calcite] KhawlaMhb commented on issue #1369: [CALCITE-2979] Add a block-based nested loop join algorithm (Khawla Mouhoubi)

KhawlaMhb commented on issue #1369: [CALCITE-2979] Add a block-based nested loop join algorithm (Khawla Mouhoubi)
URL: https://github.com/apache/calcite/pull/1369#issuecomment-522993601
 
 
   @julianhyde Thank you for the comments. I have applied point 1 & 3 to the javadoc. 
   Regarding point 2 since the method is quite long and complicated I believe starting with naming the algorithm makes the rest of the javadoc clearer. This is also done in many methods of EnumerableDefaults (hashJoin etc.).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services