You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by aljoscha <gi...@git.apache.org> on 2015/04/09 14:28:57 UTC
[GitHub] flink pull request: [FLINK-1710] [table] Switch compile backend to...
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/584
[FLINK-1710] [table] Switch compile backend to Janino
This greatly reduces compile time while still supporting the same
feature set.
I added Janino in flink-bin/LICENSE and flink-bin/NOTICE. I hope this is correct. Can someone comment on this?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink table-janino
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/584.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #584
----
commit 21d85679b4b8fb47c8b0200cc06d7a39b188be69
Author: Aljoscha Krettek <al...@gmail.com>
Date: 2015-04-07T16:11:16Z
[FLINK-1710] [table] Switch compile backend to Janino
This greatly reduces compile time while still supporting the same
feature set.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1710] [table] Switch compile backend to...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/584#issuecomment-91553317
Do we have a breakdown on how much time gets spent in what parts?
- Client
- execution
- compilation inside the runtime
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1710] [table] Switch compile backend to...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/584#issuecomment-91554708
What do you mean by execution? I would imagine that all of these are a couple of milliseconds only. When you run all the Table API tests and IT cases in your IDE the tests fly by in about 5 seconds.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1710] [table] Switch compile backend to...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/584#issuecomment-91325622
Looks good!
Any concrete numbers in how the compile time changes? I assume this is now shipping java code strings which get compiled in each function / serializer / comparator?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1710] [table] Switch compile backend to...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/584#issuecomment-91475335
Correct, we ship java code in a String that is then compiled and invoked by proxy functions.
On my machine, the time spent in mvn verify on flink-table goes down from about 2:45 to 45 seconds. On travis it goes down from 7 min to about 2 min.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1710] [table] Switch compile backend to...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/584
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---