You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/10/07 09:19:58 UTC

[GitHub] [skywalking-banyandb] hanahmily opened a new pull request, #185: Make import order deterministic

hanahmily opened a new pull request, #185:
URL: https://github.com/apache/skywalking-banyandb/pull/185

   Use `gci` in place of `goimports` to split all import blocks into three sections:
   
   - standard: Golang official imports, like "fmt"
   - default: All rest of import blocks
   - banyandb: Use a prefix match: `github.com/apache/skywalking-banyandb`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-banyandb] wu-sheng merged pull request #185: Make import order deterministic

Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #185:
URL: https://github.com/apache/skywalking-banyandb/pull/185


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-banyandb] codecov-commenter commented on pull request #185: Make import order deterministic

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #185:
URL: https://github.com/apache/skywalking-banyandb/pull/185#issuecomment-1271345784

   # [Codecov](https://codecov.io/gh/apache/skywalking-banyandb/pull/185?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#185](https://codecov.io/gh/apache/skywalking-banyandb/pull/185?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (05b68ea) into [main](https://codecov.io/gh/apache/skywalking-banyandb/commit/4bfbb842cc20a8cc1647a9ebcbd0278c33f4d6c3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4bfbb84) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   ```diff
   @@           Coverage Diff           @@
   ##             main     #185   +/-   ##
   =======================================
     Coverage   41.18%   41.18%           
   =======================================
     Files          73       73           
     Lines        6813     6813           
   =======================================
     Hits         2806     2806           
     Misses       3747     3747           
     Partials      260      260           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking-banyandb/pull/185?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [banyand/stream/metadata.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/185/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFueWFuZC9zdHJlYW0vbWV0YWRhdGEuZ28=) | `53.54% <ø> (ø)` | |
   | [banyand/tsdb/block.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/185/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFueWFuZC90c2RiL2Jsb2NrLmdv) | `65.89% <ø> (ø)` | |
   | [banyand/tsdb/retention.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/185/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFueWFuZC90c2RiL3JldGVudGlvbi5nbw==) | `72.22% <ø> (ø)` | |
   | [banyand/tsdb/segment.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/185/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFueWFuZC90c2RiL3NlZ21lbnQuZ28=) | `66.20% <ø> (ø)` | |
   | [bydbctl/internal/cmd/group.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/185/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnlkYmN0bC9pbnRlcm5hbC9jbWQvZ3JvdXAuZ28=) | `72.34% <ø> (ø)` | |
   | [bydbctl/internal/cmd/root.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/185/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnlkYmN0bC9pbnRlcm5hbC9jbWQvcm9vdC5nbw==) | `82.35% <ø> (ø)` | |
   | [bydbctl/internal/cmd/stream.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/185/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnlkYmN0bC9pbnRlcm5hbC9jbWQvc3RyZWFtLmdv) | `81.30% <ø> (ø)` | |
   | [bydbctl/internal/cmd/use.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/185/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnlkYmN0bC9pbnRlcm5hbC9jbWQvdXNlLmdv) | `42.85% <ø> (ø)` | |
   | [pkg/index/lsm/lsm.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/185/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZGV4L2xzbS9sc20uZ28=) | `65.51% <ø> (ø)` | |
   | [pkg/query/logical/measure/schema.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/185/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3F1ZXJ5L2xvZ2ljYWwvbWVhc3VyZS9zY2hlbWEuZ28=) | `0.00% <ø> (ø)` | |
   | ... and [1 more](https://codecov.io/gh/apache/skywalking-banyandb/pull/185/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org