You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by ad...@apache.org on 2016/09/26 19:25:05 UTC

[4/6] kudu git commit: thirdparty: upgrade cmake to 3.6.1

thirdparty: upgrade cmake to 3.6.1

3.6.1 is the latest version available on the website.

The new minimum is 3.4.3 because that's the oldest version that can build
LLVM 3.9. For reference, Ubuntu 16.04 currently provides 3.5.1.

Change-Id: I8d89d02eedced4e591d0c8b6b69458abe4b62175
Reviewed-on: http://gerrit.cloudera.org:8080/4506
Reviewed-by: Dan Burkert <da...@cloudera.com>
Tested-by: Adar Dembo <ad...@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/1670a89f
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/1670a89f
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/1670a89f

Branch: refs/heads/master
Commit: 1670a89f4c1aff9a839efd0cb9d7eb59a355e6f1
Parents: a3b54bb
Author: Adar Dembo <ad...@cloudera.com>
Authored: Fri Sep 2 15:39:34 2016 -0700
Committer: Adar Dembo <ad...@cloudera.com>
Committed: Mon Sep 26 19:22:31 2016 +0000

----------------------------------------------------------------------
 CMakeLists.txt     | 6 +++---
 thirdparty/vars.sh | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/1670a89f/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 9b6c40a..1f04bb8 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -15,12 +15,12 @@
 # specific language governing permissions and limitations
 # under the License.
 
-# Require cmake that supports BYPRODUCTS in add_custom_command() [1].
+# Require cmake that can build LLVM [1].
 #
 # Note: cmake in thirdparty/ will always meet this minimum.
 #
-# 1. https://cmake.org/Bug/view.php?id=14963
-cmake_minimum_required(VERSION 3.2.0)
+# 1. http://llvm.org/releases/3.9.0/docs/ReleaseNotes.html
+cmake_minimum_required(VERSION 3.4.3)
 
 # Prevent builds from the top-level source directory. This ensures that build
 # output is well isolated from the source tree.

http://git-wip-us.apache.org/repos/asf/kudu/blob/1670a89f/thirdparty/vars.sh
----------------------------------------------------------------------
diff --git a/thirdparty/vars.sh b/thirdparty/vars.sh
index 37f7c25..a477abb 100644
--- a/thirdparty/vars.sh
+++ b/thirdparty/vars.sh
@@ -44,7 +44,7 @@ GPERFTOOLS_DIR=$TP_DIR/gperftools-$GPERFTOOLS_VERSION
 PROTOBUF_VERSION=2.6.1
 PROTOBUF_DIR=$TP_DIR/protobuf-$PROTOBUF_VERSION
 
-CMAKE_VERSION=3.2.3
+CMAKE_VERSION=3.6.1
 CMAKE_DIR=$TP_DIR/cmake-${CMAKE_VERSION}
 
 SNAPPY_VERSION=1.1.0