You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@struts.apache.org by gv...@apache.org on 2006/05/26 17:26:22 UTC

svn commit: r409681 - in /struts/shale/trunk/core-library/src/java/org/apache/shale: component/ValidatorScript.java renderer/ValidatorInputRenderer.java

Author: gvanmatre
Date: Fri May 26 08:26:22 2006
New Revision: 409681

URL: http://svn.apache.org/viewvc?rev=409681&view=rev
Log:
Fix for issue SHALE-180 reported by James Reynolds.

Modified:
    struts/shale/trunk/core-library/src/java/org/apache/shale/component/ValidatorScript.java
    struts/shale/trunk/core-library/src/java/org/apache/shale/renderer/ValidatorInputRenderer.java

Modified: struts/shale/trunk/core-library/src/java/org/apache/shale/component/ValidatorScript.java
URL: http://svn.apache.org/viewvc/struts/shale/trunk/core-library/src/java/org/apache/shale/component/ValidatorScript.java?rev=409681&r1=409680&r2=409681&view=diff
==============================================================================
--- struts/shale/trunk/core-library/src/java/org/apache/shale/component/ValidatorScript.java (original)
+++ struts/shale/trunk/core-library/src/java/org/apache/shale/component/ValidatorScript.java Fri May 26 08:26:22 2006
@@ -207,7 +207,7 @@
      * @param context The FacesContext for this request
      */
    private void findCommonsValidators(UIComponent c, FacesContext context) {
-      if (c instanceof EditableValueHolder) {
+      if (c instanceof EditableValueHolder && c.isRendered()) {
          EditableValueHolder h = (EditableValueHolder) c;
          javax.faces.validator.Validator[] vs = h.getValidators();
          for (int i = 0; i < vs.length; i++) {

Modified: struts/shale/trunk/core-library/src/java/org/apache/shale/renderer/ValidatorInputRenderer.java
URL: http://svn.apache.org/viewvc/struts/shale/trunk/core-library/src/java/org/apache/shale/renderer/ValidatorInputRenderer.java?rev=409681&r1=409680&r2=409681&view=diff
==============================================================================
--- struts/shale/trunk/core-library/src/java/org/apache/shale/renderer/ValidatorInputRenderer.java (original)
+++ struts/shale/trunk/core-library/src/java/org/apache/shale/renderer/ValidatorInputRenderer.java Fri May 26 08:26:22 2006
@@ -78,7 +78,9 @@
            component.getAttributes().put(VALIDATOR_CLIENTIDS_ATTR, ids);
         }
         
-        ids.add(component.getClientId(context));
+        if (component.isRendered())
+            ids.add(component.getClientId(context));
+        
         defaultRenderer.encodeBegin(context, component);
     }