You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2020/04/08 09:35:50 UTC

[GitHub] [zeppelin] zjffdu opened a new pull request #3726: [ZEPPELIN-4735]. Fail to getCompletion when interpreter doesn't implement completion

zjffdu opened a new pull request #3726: [ZEPPELIN-4735]. Fail to getCompletion when interpreter doesn't implement completion
URL: https://github.com/apache/zeppelin/pull/3726
 
 
   ### What is this PR for?
   
   Trivial PR which only return empty list instead of null. 
   
   
   ### What type of PR is it?
   [Bug Fix]
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/ZEPPELIN-4735
   
   ### How should this be tested?
   * Manually tested
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] zjffdu commented on a change in pull request #3726: [ZEPPELIN-4735]. Fail to getCompletion when interpreter doesn't implement completion

Posted by GitBox <gi...@apache.org>.
zjffdu commented on a change in pull request #3726: [ZEPPELIN-4735]. Fail to getCompletion when interpreter doesn't implement completion
URL: https://github.com/apache/zeppelin/pull/3726#discussion_r405402657
 
 

 ##########
 File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/Interpreter.java
 ##########
 @@ -156,7 +157,7 @@ public abstract InterpreterResult interpret(String st,
   @ZeppelinApi
   public List<InterpreterCompletion> completion(String buf, int cursor,
       InterpreterContext interpreterContext) throws InterpreterException {
-    return null;
+    return new ArrayList<>();
 
 Review comment:
   Good point, will fix it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] asfgit closed pull request #3726: [ZEPPELIN-4735]. Fail to getCompletion when interpreter doesn't implement completion

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3726: [ZEPPELIN-4735]. Fail to getCompletion when interpreter doesn't implement completion
URL: https://github.com/apache/zeppelin/pull/3726
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] alexott commented on a change in pull request #3726: [ZEPPELIN-4735]. Fail to getCompletion when interpreter doesn't implement completion

Posted by GitBox <gi...@apache.org>.
alexott commented on a change in pull request #3726: [ZEPPELIN-4735]. Fail to getCompletion when interpreter doesn't implement completion
URL: https://github.com/apache/zeppelin/pull/3726#discussion_r405401484
 
 

 ##########
 File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/Interpreter.java
 ##########
 @@ -156,7 +157,7 @@ public abstract InterpreterResult interpret(String st,
   @ZeppelinApi
   public List<InterpreterCompletion> completion(String buf, int cursor,
       InterpreterContext interpreterContext) throws InterpreterException {
-    return null;
+    return new ArrayList<>();
 
 Review comment:
   do we need mutable List here? If not, can we use `Collections.emptyList()` ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services