You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/01/23 15:50:52 UTC

[GitHub] astonzhang commented on issue #9514: Language Modeling Datasets and Sampler

astonzhang commented on issue #9514: Language Modeling Datasets and Sampler
URL: https://github.com/apache/incubator-mxnet/pull/9514#issuecomment-359833763
 
 
   I would like to propose the following change for class names:
   TokenIndexer -> Vocabulary
   Glossary -> VocabularyEmbedding
   TokenEmbedding -> PretrainedEmbedding
   
   Otherwise, having both Vocabulary and Glossary is likely confusing. Having both VocabularyEmbedding and TokenEmbedding is also likely confusing. 
   
   Is the proposed change OK?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services