You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Damian Mehers (JIRA)" <ji...@apache.org> on 2011/01/11 14:37:07 UTC
[jira] Created: (THRIFT-1037) Proposed changes to support
Silverlight and Windows Phone
Proposed changes to support Silverlight and Windows Phone
---------------------------------------------------------
Key: THRIFT-1037
URL: https://issues.apache.org/jira/browse/THRIFT-1037
Project: Thrift
Issue Type: Improvement
Components: C# - Compiler, C# - Library
Reporter: Damian Mehers
I've made some changes to the C# compiler and library to support Silverlight and Windows Phone 7. I'd appreciate other people's thoughts before I submit a patch.
The changes are described and available here: http://damianblog.com/2011/01/11/generating-silverlight-windows-phone-compatible-thrift-proxies/
If you'd prefer that I submit a patch first then no problem.
Thanks,
Damian
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Resolved] (THRIFT-1037) Proposed changes to support
Silverlight, Windows Phone and AsyncCTP v3
Posted by "Roger Meier (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Meier resolved THRIFT-1037.
---------------------------------
Resolution: Fixed
Assignee: Jens Geyer
committed!
Thanks Damian for initial efforts and Jens for integration work!
-roger
> Proposed changes to support Silverlight, Windows Phone and AsyncCTP v3
> ----------------------------------------------------------------------
>
> Key: THRIFT-1037
> URL: https://issues.apache.org/jira/browse/THRIFT-1037
> Project: Thrift
> Issue Type: Improvement
> Components: C# - Compiler, C# - Library
> Reporter: Damian Mehers
> Assignee: Jens Geyer
> Attachments: THRIFT-1037_Proposed_changes_to_support_Silverlight_Windows_Phone_and_AsyncCTP.patch
>
>
> I've made some changes to the C# compiler and library to support Silverlight and Windows Phone 7. I'd appreciate other people's thoughts before I submit a patch.
> The changes are described and available here: http://damianblog.com/2011/01/11/generating-silverlight-windows-phone-compatible-thrift-proxies/
> If you'd prefer that I submit a patch first then no problem.
> Thanks,
> Damian
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1037) Proposed changes to support
Silverlight, Windows Phone and AsyncCTP v3
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165225#comment-13165225 ]
Hudson commented on THRIFT-1037:
--------------------------------
Integrated in Thrift #353 (See [https://builds.apache.org/job/Thrift/353/])
THRIFT-1037 Proposed changes to support Silverlight, Windows Phone and AsyncCTP v3
Patch: Damian Mehers & Jens Geyer
roger : http://svn.apache.org/viewvc/?view=rev&rev=1211880
Files :
* /thrift/trunk/compiler/cpp/src/generate/t_csharp_generator.cc
* /thrift/trunk/lib/csharp/src/Collections/THashSet.cs
* /thrift/trunk/lib/csharp/src/Properties/AssemblyInfo.WP7.cs
* /thrift/trunk/lib/csharp/src/Protocol/TBinaryProtocol.cs
* /thrift/trunk/lib/csharp/src/Protocol/TJSONProtocol.cs
* /thrift/trunk/lib/csharp/src/Protocol/TProtocol.cs
* /thrift/trunk/lib/csharp/src/Thrift.WP7.csproj
* /thrift/trunk/lib/csharp/src/Transport/THttpClient.cs
* /thrift/trunk/lib/csharp/src/Transport/TTransport.cs
> Proposed changes to support Silverlight, Windows Phone and AsyncCTP v3
> ----------------------------------------------------------------------
>
> Key: THRIFT-1037
> URL: https://issues.apache.org/jira/browse/THRIFT-1037
> Project: Thrift
> Issue Type: Improvement
> Components: C# - Compiler, C# - Library
> Reporter: Damian Mehers
> Assignee: Jens Geyer
> Attachments: THRIFT-1037_Proposed_changes_to_support_Silverlight_Windows_Phone_and_AsyncCTP.patch
>
>
> I've made some changes to the C# compiler and library to support Silverlight and Windows Phone 7. I'd appreciate other people's thoughts before I submit a patch.
> The changes are described and available here: http://damianblog.com/2011/01/11/generating-silverlight-windows-phone-compatible-thrift-proxies/
> If you'd prefer that I submit a patch first then no problem.
> Thanks,
> Damian
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (THRIFT-1037) Proposed changes to support
Silverlight and Windows Phone
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980677#action_12980677 ]
Roger Meier commented on THRIFT-1037:
-------------------------------------
Cool! There are several users that look for that feature.
Yes, please submit a patch. see: http://wiki.apache.org/thrift/HowToContribute
> Proposed changes to support Silverlight and Windows Phone
> ---------------------------------------------------------
>
> Key: THRIFT-1037
> URL: https://issues.apache.org/jira/browse/THRIFT-1037
> Project: Thrift
> Issue Type: Improvement
> Components: C# - Compiler, C# - Library
> Reporter: Damian Mehers
>
> I've made some changes to the C# compiler and library to support Silverlight and Windows Phone 7. I'd appreciate other people's thoughts before I submit a patch.
> The changes are described and available here: http://damianblog.com/2011/01/11/generating-silverlight-windows-phone-compatible-thrift-proxies/
> If you'd prefer that I submit a patch first then no problem.
> Thanks,
> Damian
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Commented] (THRIFT-1037) Proposed changes to support
Silverlight, Windows Phone and AsyncCTP v3
Posted by "Damian Mehers (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165232#comment-13165232 ]
Damian Mehers commented on THRIFT-1037:
---------------------------------------
Just a quick comment to confirm my approval of Jens' work submitting this patch - thanks Jens!
Damian
> Proposed changes to support Silverlight, Windows Phone and AsyncCTP v3
> ----------------------------------------------------------------------
>
> Key: THRIFT-1037
> URL: https://issues.apache.org/jira/browse/THRIFT-1037
> Project: Thrift
> Issue Type: Improvement
> Components: C# - Compiler, C# - Library
> Reporter: Damian Mehers
> Assignee: Jens Geyer
> Attachments: THRIFT-1037_Proposed_changes_to_support_Silverlight_Windows_Phone_and_AsyncCTP.patch
>
>
> I've made some changes to the C# compiler and library to support Silverlight and Windows Phone 7. I'd appreciate other people's thoughts before I submit a patch.
> The changes are described and available here: http://damianblog.com/2011/01/11/generating-silverlight-windows-phone-compatible-thrift-proxies/
> If you'd prefer that I submit a patch first then no problem.
> Thanks,
> Damian
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1037) Proposed changes to support
Silverlight, Windows Phone and AsyncCTP v3
Posted by "Jens Geyer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jens Geyer updated THRIFT-1037:
-------------------------------
Patch Info: Patch Available
Summary: Proposed changes to support Silverlight, Windows Phone and AsyncCTP v3 (was: Proposed changes to support Silverlight and Windows Phone)
> Proposed changes to support Silverlight, Windows Phone and AsyncCTP v3
> ----------------------------------------------------------------------
>
> Key: THRIFT-1037
> URL: https://issues.apache.org/jira/browse/THRIFT-1037
> Project: Thrift
> Issue Type: Improvement
> Components: C# - Compiler, C# - Library
> Reporter: Damian Mehers
> Attachments: THRIFT-1037_Proposed_changes_to_support_Silverlight_Windows_Phone_and_AsyncCTP.patch
>
>
> I've made some changes to the C# compiler and library to support Silverlight and Windows Phone 7. I'd appreciate other people's thoughts before I submit a patch.
> The changes are described and available here: http://damianblog.com/2011/01/11/generating-silverlight-windows-phone-compatible-thrift-proxies/
> If you'd prefer that I submit a patch first then no problem.
> Thanks,
> Damian
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1037) Proposed changes to support
Silverlight and Windows Phone
Posted by "Jens Geyer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jens Geyer updated THRIFT-1037:
-------------------------------
Attachment: THRIFT-1037_Proposed_changes_to_support_Silverlight_Windows_Phone_and_AsyncCTP.patch
With permission from Damian, I provide this patch which is mostly based on Damian's modifications to both C# library and compiler. I took the files he had published on his blog.
I made only some further minor modifications to it:
- added a new "async" switch which generates code in order to support the AsyncCTP v3. (see http://www.microsoft.com/download/en/details.aspx?id=9983)
- added a new project file for a separate Thrift.WP7 assembly
What is still missing:
- The MSBuildTask has not been changed. I have no opportunity to test that and would like to leave this task to someone else who can.
> Proposed changes to support Silverlight and Windows Phone
> ---------------------------------------------------------
>
> Key: THRIFT-1037
> URL: https://issues.apache.org/jira/browse/THRIFT-1037
> Project: Thrift
> Issue Type: Improvement
> Components: C# - Compiler, C# - Library
> Reporter: Damian Mehers
> Attachments: THRIFT-1037_Proposed_changes_to_support_Silverlight_Windows_Phone_and_AsyncCTP.patch
>
>
> I've made some changes to the C# compiler and library to support Silverlight and Windows Phone 7. I'd appreciate other people's thoughts before I submit a patch.
> The changes are described and available here: http://damianblog.com/2011/01/11/generating-silverlight-windows-phone-compatible-thrift-proxies/
> If you'd prefer that I submit a patch first then no problem.
> Thanks,
> Damian
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira