You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by GitBox <gi...@apache.org> on 2022/04/05 15:48:43 UTC
[GitHub] [myfaces] melloware opened a new pull request, #245: Faces 4.0 use JDK 11
melloware opened a new pull request, #245:
URL: https://github.com/apache/myfaces/pull/245
I noticed this when switching branches that Faces 4.0 is still set for JDK 8 but its using JDK 11 features.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] volosied merged pull request #245: Faces 4.0 use JDK 11
Posted by GitBox <gi...@apache.org>.
volosied merged PR #245:
URL: https://github.com/apache/myfaces/pull/245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] volosied commented on pull request #245: Faces 4.0 use JDK 11
Posted by GitBox <gi...@apache.org>.
volosied commented on PR #245:
URL: https://github.com/apache/myfaces/pull/245#issuecomment-1097160701
Can you update [integration-tests/pom.xml](https://github.com/apache/myfaces/pull/245/files#diff-3b7c131fb9becff591ff3eb25a6b91b29420703e244fadc2096277504d3a2ae1) to use java.version?
Easier to update next time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] melloware commented on pull request #245: Faces 4.0 use JDK 11
Posted by GitBox <gi...@apache.org>.
melloware commented on PR #245:
URL: https://github.com/apache/myfaces/pull/245#issuecomment-1097226238
Felix blew up on one of the builds so I was concerned it was jdk 11 related so updated the plug-in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] volosied commented on pull request #245: Faces 4.0 use JDK 11
Posted by GitBox <gi...@apache.org>.
volosied commented on PR #245:
URL: https://github.com/apache/myfaces/pull/245#issuecomment-1097201192
Looks good! What's the felix update?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] volosied commented on pull request #245: Faces 4.0 use JDK 11
Posted by GitBox <gi...@apache.org>.
volosied commented on PR #245:
URL: https://github.com/apache/myfaces/pull/245#issuecomment-1098237577
Tested locally -- build finished successfully.
Merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] melloware commented on pull request #245: Faces 4.0 use JDK 11
Posted by GitBox <gi...@apache.org>.
melloware commented on PR #245:
URL: https://github.com/apache/myfaces/pull/245#issuecomment-1097164110
Fixed. Wow this was in a lot of places 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] melloware commented on pull request #245: Faces 4.0 use JDK 11
Posted by GitBox <gi...@apache.org>.
melloware commented on PR #245:
URL: https://github.com/apache/myfaces/pull/245#issuecomment-1097147979
Good catch found a couple of more places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] volosied commented on pull request #245: Faces 4.0 use JDK 11
Posted by GitBox <gi...@apache.org>.
volosied commented on PR #245:
URL: https://github.com/apache/myfaces/pull/245#issuecomment-1097143272
Should you also update
parent / pom.xml
```
<plugin>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.6.1</version>
<configuration>
<source>1.8</source>
<target>1.8</target>
</configuration>
</plugin>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] volosied commented on pull request #245: Faces 4.0 use JDK 11
Posted by GitBox <gi...@apache.org>.
volosied commented on PR #245:
URL: https://github.com/apache/myfaces/pull/245#issuecomment-1097160038
I also see 8 used in line 219: https://github.com/apache/myfaces/pull/245/files#diff-b5a06276719e759fe07dfe6f75d781be5f83d2215179d82bdb195ad035348214R219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org