You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Anita Anandan <an...@oracle.com> on 2008/10/21 21:46:50 UTC

TRINIDAD-1262

Hi all -

I was wondering if one of the Trinidad committees could take a look at 
trinidad-1262 (https://issues.apache.org/jira/browse/TRINIDAD-1262)? It 
needs to be reviewed and committed.

Thanks
Anita

Re: TRINIDAD-1262

Posted by Anita Anandan <an...@oracle.com>.
Done.

Thanks Matthias.
-Anita

Matthias Wessendorf wrote:
> looks good so far.
>
> I just wonder if this:
> +      Locale locale = getLocale();
> +      if (null == locale)
> +      {
> +        RequestContext reqContext = RequestContext.getCurrentInstance();
> +        if (reqContext != null)
> +        {
> +          locale = reqContext.getFormattingLocale();
> +        }
> +        if (locale == null)
> +        {
> +           locale = context.getViewRoot().getLocale();
> +        }
> +      }
>
> could be moved to a private function, since some other place is doing
> the same, I think
>
> -M
>
> On Tue, Oct 21, 2008 at 9:46 PM, Anita Anandan <an...@oracle.com> wrote:
>   
>> Hi all -
>>
>> I was wondering if one of the Trinidad committees could take a look at
>> trinidad-1262 (https://issues.apache.org/jira/browse/TRINIDAD-1262)? It
>> needs to be reviewed and committed.
>>
>> Thanks
>> Anita
>>
>>     
>
>
>
>

Re: TRINIDAD-1262

Posted by Matthias Wessendorf <ma...@apache.org>.
looks good so far.

I just wonder if this:
+      Locale locale = getLocale();
+      if (null == locale)
+      {
+        RequestContext reqContext = RequestContext.getCurrentInstance();
+        if (reqContext != null)
+        {
+          locale = reqContext.getFormattingLocale();
+        }
+        if (locale == null)
+        {
+           locale = context.getViewRoot().getLocale();
+        }
+      }

could be moved to a private function, since some other place is doing
the same, I think

-M

On Tue, Oct 21, 2008 at 9:46 PM, Anita Anandan <an...@oracle.com> wrote:
> Hi all -
>
> I was wondering if one of the Trinidad committees could take a look at
> trinidad-1262 (https://issues.apache.org/jira/browse/TRINIDAD-1262)? It
> needs to be reviewed and committed.
>
> Thanks
> Anita
>



-- 
Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf