You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Ekaterina Dimitrova (Jira)" <ji...@apache.org> on 2022/09/02 15:15:00 UTC
[jira] [Updated] (CASSANDRA-17873) Opcodes.ASM7 should be used in UDFByteCodeVerifier to support JDK11
[ https://issues.apache.org/jira/browse/CASSANDRA-17873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ekaterina Dimitrova updated CASSANDRA-17873:
--------------------------------------------
Test and Documentation Plan:
||Branch||CI run||
|[4.0|https://github.com/ekaterinadimitrova2/cassandra/tree/17873-4.0]|[CircleCI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17873-4.0]|
|[4.1|https://github.com/ekaterinadimitrova2/cassandra/tree/17873-4.1]|[CircleCI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17873-4.1]|
|[trunk|https://github.com/ekaterinadimitrova2/cassandra/tree/17873-trunk]|[CircleCI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17873-trunk] #1878 is the full CI run|
All known flaky tests:
4.0:
* testDropCompactStorage - CASSANDRA-17674
4.1:
* test_multiple_repair - CASSANDRA-17005, known timeouts. Probably will reopen that ticket or open a new one but not related to this work
* test_failed_bootstrap_wiped_node_can_join - CASSANDRA-17308
trunk:
* nodeDownDuringMove - CASSANDRA-15239, also in this case I suspect some Circle issue, I am spinning things in a loop to add more info to that ticket but I don't think this failure has anything to do with this particular work
* test_failed_bootstrap_wiped_node_can_join - CASSANDRA-17308
Status: Patch Available (was: In Progress)
> Opcodes.ASM7 should be used in UDFByteCodeVerifier to support JDK11
> -------------------------------------------------------------------
>
> Key: CASSANDRA-17873
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17873
> Project: Cassandra
> Issue Type: Bug
> Components: Build, Dependencies, Feature/UDF
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.0.x, 4.1-rc, 4.1.x, 4.x
>
>
> In CASSANDRA-15108 ASM was updated and UDFByteCodeVerifier was updated to provide Opcodes.ASM7 but only in 1 of 3 places.
> We need to update that for 4.0, 4.1 and trunk where we support JDK11.
> Also, I think it will be good to add one place where we update that when we add new JDK support as now I see we will have to update it at 4 places at least already (also for the simulator where currently it is Opcodes.ASM7 there, correctly added). Also, we can add a note in build.xml for people updating ASM. I think many people practice updating Opcodes.ASM* with the update of ASM version but in our case with update of JDK, from what I see. We will need to switch to ASM9 when we add the JDK 17 support. One stop place for that and adding a note for maintainers sounds like the right way to move forward at least on trunk.
> But for 4.0 and 4.1 we need at least to switch to ASM7 everywhere as far as I can tell.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org