You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by mi...@apache.org on 2016/04/11 11:24:13 UTC
lucene-solr:branch_6_0: fix rare test bug
Repository: lucene-solr
Updated Branches:
refs/heads/branch_6_0 36a48e4df -> 9a2645d4d
fix rare test bug
Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/9a2645d4
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/9a2645d4
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/9a2645d4
Branch: refs/heads/branch_6_0
Commit: 9a2645d4d68d73f8d9afbf9323f5a7acb8f4eff2
Parents: 36a48e4
Author: Mike McCandless <mi...@apache.org>
Authored: Mon Apr 11 05:24:34 2016 -0400
Committer: Mike McCandless <mi...@apache.org>
Committed: Mon Apr 11 05:25:58 2016 -0400
----------------------------------------------------------------------
.../lucene/facet/range/TestRangeFacetCounts.java | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/9a2645d4/lucene/facet/src/test/org/apache/lucene/facet/range/TestRangeFacetCounts.java
----------------------------------------------------------------------
diff --git a/lucene/facet/src/test/org/apache/lucene/facet/range/TestRangeFacetCounts.java b/lucene/facet/src/test/org/apache/lucene/facet/range/TestRangeFacetCounts.java
index 626d772..18645e7 100644
--- a/lucene/facet/src/test/org/apache/lucene/facet/range/TestRangeFacetCounts.java
+++ b/lucene/facet/src/test/org/apache/lucene/facet/range/TestRangeFacetCounts.java
@@ -22,14 +22,14 @@ import java.util.Map;
import java.util.Set;
import java.util.concurrent.atomic.AtomicBoolean;
-import org.apache.lucene.document.DoublePoint;
-import org.apache.lucene.document.LongPoint;
import org.apache.lucene.document.Document;
import org.apache.lucene.document.DoubleDocValuesField;
+import org.apache.lucene.document.DoublePoint;
+import org.apache.lucene.document.LongPoint;
import org.apache.lucene.document.NumericDocValuesField;
import org.apache.lucene.facet.DrillDownQuery;
-import org.apache.lucene.facet.DrillSideways;
import org.apache.lucene.facet.DrillSideways.DrillSidewaysResult;
+import org.apache.lucene.facet.DrillSideways;
import org.apache.lucene.facet.FacetField;
import org.apache.lucene.facet.FacetResult;
import org.apache.lucene.facet.FacetTestCase;
@@ -59,6 +59,7 @@ import org.apache.lucene.search.Scorer;
import org.apache.lucene.search.Weight;
import org.apache.lucene.store.Directory;
import org.apache.lucene.util.IOUtils;
+import org.apache.lucene.util.NumericUtils;
import org.apache.lucene.util.TestUtil;
public class TestRangeFacetCounts extends FacetTestCase {
@@ -532,7 +533,11 @@ public class TestRangeFacetCounts extends FacetTestCase {
boolean minIncl;
boolean maxIncl;
- if (min == max) {
+
+ long minAsLong = NumericUtils.doubleToSortableLong(min);
+ long maxAsLong = NumericUtils.doubleToSortableLong(max);
+ // NOTE: maxAsLong - minAsLong >= 0 is here to handle the common overflow case!
+ if (maxAsLong - minAsLong >= 0 && maxAsLong - minAsLong < 2) {
minIncl = true;
maxIncl = true;
} else {