You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by Ignasi Barrera <no...@github.com> on 2016/08/01 08:24:16 UTC

Re: [jclouds/jclouds-labs-google] add firewalls conditionally (#172)

>        Network network = getOrCreateNetwork(templateOptions, sharedResourceName);
> -      getOrCreateFirewalls(templateOptions, network, firewallTagNamingConvention.get(group));
> +      // add firewalls *only* if the template options don't contain explicit network
> +      if (templateOptions.network() == null) {

Could you explain the rationale behind this change? The network will exist (or will be created) regardless of whether the user configured it n the template options. Why should we create the firewalls only if the user did not configure the network?

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/172/files/a083442f462a4b5dcc0c9dabfcca8a181b8e2889#r72939751