You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Dongjoon Hyun (JIRA)" <ji...@apache.org> on 2016/07/27 20:34:20 UTC

[jira] [Commented] (SPARK-16756) Add `sql` function to LogicalPlan and `NonSQLPlan` trait

    [ https://issues.apache.org/jira/browse/SPARK-16756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396321#comment-15396321 ] 

Dongjoon Hyun commented on SPARK-16756:
---------------------------------------

Hi, [~rxin].
So far, I've been working in this direction. I'll make a PR after completing full SQL generation.
Since this is a design choice, could you give me some opinion on this direction?

> Add `sql` function to LogicalPlan and `NonSQLPlan` trait
> --------------------------------------------------------
>
>                 Key: SPARK-16756
>                 URL: https://issues.apache.org/jira/browse/SPARK-16756
>             Project: Spark
>          Issue Type: Sub-task
>          Components: SQL
>            Reporter: Dongjoon Hyun
>
> Like `Expression`, this issue adds `sql` function for `LogicalPlan` and `NonSQLPlan` trait. The method will be `abstract` method. All logical plan should implement that or use trait `NonSQLPlan` explicitly.
> {code}
> /**
>  * Returns SQL representation of this plan. For the plans extending [[NonSQLPlan]],
>  * this method may return an arbitrary user facing string.
>  */
> def sql: String
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org