You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Reza Motamedi <re...@gmail.com> on 2017/10/17 01:36:59 UTC
Review Request 63062: Adding test for neighbor panel in UI
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63062/
-----------------------------------------------------------
Review request for Aurora, David McLaughlin, Kai Huang, and Santhosh Kumar Shanmugham.
Repository: aurora
Description
-------
# Expose list of neighbors in the instance page
Exposing the list of neighbor task on the host is useful when application tail letencies degrade because of noisy neighbors. Currenlty our service oweners need to jump to the thermos-UI to get this info. This feature will definately help spotting misbehaving neighbors a lot easier.
Diffs
-----
ui/src/main/js/components/TaskNeighbors.js PRE-CREATION
ui/src/main/js/components/TaskStatus.js b5149182c80b0edcdec88d5c6e24d3015409b0fc
ui/src/main/js/components/__tests__/TaskNeighbors-test.js PRE-CREATION
ui/src/main/js/pages/Instance.js c4d625c063b6037ae2ff93e638a3040436515cd5
ui/src/main/js/utils/Common.js 8f2da7c8a5b44d2ded89a2070ea6ac4bf1fb6ed5
ui/src/main/sass/components/_instance-page.scss 99204fdfca4441d824c3dfff083f78e1d094b4c9
Diff: https://reviews.apache.org/r/63062/diff/1/
Testing
-------
? ./gradlew ui:test
? ./gradlew ui:lint
File Attachments
----------------
Screen Shot 2017-10-16 at 6.27.44 PM.png
https://reviews.apache.org/media/uploaded/files/2017/10/17/7fa71abf-f83e-412f-b554-dc880ccdb25c__Screen_Shot_2017-10-16_at_6.27.44_PM.png
Thanks,
Reza Motamedi
Re: Review Request 63062: Adding test for neighbor panel in UI
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63062/#review188255
-----------------------------------------------------------
Ship it!
Master (5b72398) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Oct. 17, 2017, 9:36 a.m., Reza Motamedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63062/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 9:36 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Kai Huang, and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> # Expose list of neighbors in the instance page
>
> Exposing the list of neighbor task on the host is useful when application tail letencies degrade because of noisy neighbors. Currenlty our service oweners need to jump to the thermos-UI to get this info. This feature will definately help spotting misbehaving neighbors a lot easier.
>
>
> Diffs
> -----
>
> ui/src/main/js/components/TaskNeighbors.js PRE-CREATION
> ui/src/main/js/components/TaskStatus.js b5149182c80b0edcdec88d5c6e24d3015409b0fc
> ui/src/main/js/components/__tests__/TaskNeighbors-test.js PRE-CREATION
> ui/src/main/js/pages/Instance.js c4d625c063b6037ae2ff93e638a3040436515cd5
> ui/src/main/js/utils/Common.js 8f2da7c8a5b44d2ded89a2070ea6ac4bf1fb6ed5
> ui/src/main/sass/components/_instance-page.scss 99204fdfca4441d824c3dfff083f78e1d094b4c9
>
>
> Diff: https://reviews.apache.org/r/63062/diff/1/
>
>
> Testing
> -------
>
> ? ./gradlew ui:test
> ? ./gradlew ui:lint
>
>
> File Attachments
> ----------------
>
> Screen Shot 2017-10-16 at 6.27.44 PM.png
> https://reviews.apache.org/media/uploaded/files/2017/10/17/7fa71abf-f83e-412f-b554-dc880ccdb25c__Screen_Shot_2017-10-16_at_6.27.44_PM.png
>
>
> Thanks,
>
> Reza Motamedi
>
>
Re: Review Request 63062: Expose list of neighbors in the instance
page
Posted by Reza Motamedi <re...@gmail.com>.
> On Oct. 17, 2017, 2:02 a.m., David McLaughlin wrote:
> > File Attachment: Screen Shot 2017-10-16 at 6.27.44 PM.png - Screen Shot 2017-10-16 at 6.27.44 PM.png
> > <https://reviews.apache.org/r/63062/#fcomment116>
> >
> > Host Neighbors?
done.
> On Oct. 17, 2017, 2:02 a.m., David McLaughlin wrote:
> > File Attachment: Screen Shot 2017-10-16 at 6.27.44 PM.png - Screen Shot 2017-10-16 at 6.27.44 PM.png
> > <https://reviews.apache.org/r/63062/#fcomment117>
> >
> > Link to instance page?
I linkified this as well.
> On Oct. 17, 2017, 2:02 a.m., David McLaughlin wrote:
> > ui/src/main/js/components/TaskNeighbors.js
> > Lines 7-12 (patched)
> > <https://reviews.apache.org/r/63062/diff/1/?file=1858879#file1858879line7>
> >
> > const { role, environment, name } = assignedTask.task.job;
> >
> > const taskKey = `${role}/${environment}/${name}/${assignedTask.instanceId}`
great, looks so much nicer. done.
> On Oct. 17, 2017, 2:02 a.m., David McLaughlin wrote:
> > ui/src/main/js/components/__tests__/TaskNeighbors-test.js
> > Lines 7 (patched)
> > <https://reviews.apache.org/r/63062/diff/1/?file=1858881#file1858881line7>
> >
> > *Should contain empty div
done.
> On Oct. 17, 2017, 2:02 a.m., David McLaughlin wrote:
> > ui/src/main/js/pages/Instance.js
> > Lines 34 (patched)
> > <https://reviews.apache.org/r/63062/diff/1/?file=1858882#file1858882line34>
> >
> > Is it not possible to unit test this without mounting the component (which I still haven't been able to figure out myself)?
I honestly don't know. I will check around some more.
- Reza
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63062/#review188254
-----------------------------------------------------------
On Oct. 17, 2017, 5:34 a.m., Reza Motamedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63062/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 5:34 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Kai Huang, and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> # Expose list of neighbors in the instance page
>
> Exposing the list of neighbor task on the host is useful when application tail letencies degrade because of noisy neighbors. Currenlty our service oweners need to jump to the thermos-UI to get this info. This feature will definately help spotting misbehaving neighbors a lot easier.
>
>
> Diffs
> -----
>
> ui/src/main/js/components/TaskNeighbors.js PRE-CREATION
> ui/src/main/js/components/TaskStatus.js b5149182c80b0edcdec88d5c6e24d3015409b0fc
> ui/src/main/js/components/__tests__/TaskNeighbors-test.js PRE-CREATION
> ui/src/main/js/pages/Instance.js c4d625c063b6037ae2ff93e638a3040436515cd5
> ui/src/main/js/utils/Common.js 8f2da7c8a5b44d2ded89a2070ea6ac4bf1fb6ed5
> ui/src/main/sass/components/_instance-page.scss 99204fdfca4441d824c3dfff083f78e1d094b4c9
>
>
> Diff: https://reviews.apache.org/r/63062/diff/3/
>
>
> Testing
> -------
>
> ? ./gradlew ui:test
> ? ./gradlew ui:lint
>
>
> File Attachments
> ----------------
>
> Screen Shot 2017-10-16 at 6.27.44 PM.png
> https://reviews.apache.org/media/uploaded/files/2017/10/17/7fa71abf-f83e-412f-b554-dc880ccdb25c__Screen_Shot_2017-10-16_at_6.27.44_PM.png
>
>
> Thanks,
>
> Reza Motamedi
>
>
Re: Review Request 63062: Adding test for neighbor panel in UI
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63062/#review188254
-----------------------------------------------------------
This is great! Just some minor feedback.
File Attachment: Screen Shot 2017-10-16 at 6.27.44 PM.png - Screen Shot 2017-10-16 at 6.27.44 PM.png
<https://reviews.apache.org//r/63062/#fcomment114>
Host Neighbors?
File Attachment: Screen Shot 2017-10-16 at 6.27.44 PM.png - Screen Shot 2017-10-16 at 6.27.44 PM.png
<https://reviews.apache.org//r/63062/#fcomment115>
Link to instance page?
ui/src/main/js/components/TaskNeighbors.js
Lines 7-12 (patched)
<https://reviews.apache.org/r/63062/#comment265255>
const { role, environment, name } = assignedTask.task.job;
const taskKey = `${role}/${environment}/${name}/${assignedTask.instanceId}`
ui/src/main/js/components/__tests__/TaskNeighbors-test.js
Lines 7 (patched)
<https://reviews.apache.org/r/63062/#comment265256>
*Should contain empty div
ui/src/main/js/pages/Instance.js
Lines 34 (patched)
<https://reviews.apache.org/r/63062/#comment265258>
Is it not possible to unit test this without mounting the component (which I still haven't been able to figure out myself)?
ui/src/main/sass/components/_instance-page.scss
Lines 22 (patched)
<https://reviews.apache.org/r/63062/#comment265257>
Remove trailing white space.
- David McLaughlin
On Oct. 17, 2017, 1:36 a.m., Reza Motamedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63062/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 1:36 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Kai Huang, and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> # Expose list of neighbors in the instance page
>
> Exposing the list of neighbor task on the host is useful when application tail letencies degrade because of noisy neighbors. Currenlty our service oweners need to jump to the thermos-UI to get this info. This feature will definately help spotting misbehaving neighbors a lot easier.
>
>
> Diffs
> -----
>
> ui/src/main/js/components/TaskNeighbors.js PRE-CREATION
> ui/src/main/js/components/TaskStatus.js b5149182c80b0edcdec88d5c6e24d3015409b0fc
> ui/src/main/js/components/__tests__/TaskNeighbors-test.js PRE-CREATION
> ui/src/main/js/pages/Instance.js c4d625c063b6037ae2ff93e638a3040436515cd5
> ui/src/main/js/utils/Common.js 8f2da7c8a5b44d2ded89a2070ea6ac4bf1fb6ed5
> ui/src/main/sass/components/_instance-page.scss 99204fdfca4441d824c3dfff083f78e1d094b4c9
>
>
> Diff: https://reviews.apache.org/r/63062/diff/1/
>
>
> Testing
> -------
>
> ? ./gradlew ui:test
> ? ./gradlew ui:lint
>
>
> File Attachments
> ----------------
>
> Screen Shot 2017-10-16 at 6.27.44 PM.png
> https://reviews.apache.org/media/uploaded/files/2017/10/17/7fa71abf-f83e-412f-b554-dc880ccdb25c__Screen_Shot_2017-10-16_at_6.27.44_PM.png
>
>
> Thanks,
>
> Reza Motamedi
>
>
Re: Review Request 63062: Adding test for neighbor panel in UI
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63062/#review188272
-----------------------------------------------------------
Master (5b72398) is red with this patch.
./build-support/jenkins/build.sh
:processJmhResources NO-SOURCE
:jmhClasses
:checkstyleJmh
:checkstyleMain
:checkstyleTest
:findbugsJmh
:findbugsMain
:findbugsTest
:licenseJmh UP-TO-DATE
:licenseMain UP-TO-DATE
:licenseTest UP-TO-DATE
:license UP-TO-DATE
:pmdJmh
:pmdMain
:pmdTest
:test
org.apache.aurora.scheduler.events.WebhookTest > testTaskChangedWithOldStateError FAILED
java.lang.AssertionError at WebhookTest.java:203
I1017 05:28:17.836 [ShutdownHook, SchedulerMain] Stopping scheduler services.
1140 tests completed, 1 failed, 2 skipped
:test FAILED
:jacocoTestReport
Coverage report generated: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html
:jacocoTestCoverageVerification
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':test'.
> There were failing tests. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/tests/test/index.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
* Get more help at https://help.gradle.org
BUILD FAILED in 7m 22s
48 actionable tasks: 39 executed, 9 up-to-date
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Oct. 17, 2017, 1:19 p.m., Reza Motamedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63062/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 1:19 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Kai Huang, and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> # Expose list of neighbors in the instance page
>
> Exposing the list of neighbor task on the host is useful when application tail letencies degrade because of noisy neighbors. Currenlty our service oweners need to jump to the thermos-UI to get this info. This feature will definately help spotting misbehaving neighbors a lot easier.
>
>
> Diffs
> -----
>
> ui/src/main/js/components/TaskNeighbors.js PRE-CREATION
> ui/src/main/js/components/TaskStatus.js b5149182c80b0edcdec88d5c6e24d3015409b0fc
> ui/src/main/js/components/__tests__/TaskNeighbors-test.js PRE-CREATION
> ui/src/main/js/pages/Instance.js c4d625c063b6037ae2ff93e638a3040436515cd5
> ui/src/main/js/utils/Common.js 8f2da7c8a5b44d2ded89a2070ea6ac4bf1fb6ed5
> ui/src/main/sass/components/_instance-page.scss 99204fdfca4441d824c3dfff083f78e1d094b4c9
>
>
> Diff: https://reviews.apache.org/r/63062/diff/2/
>
>
> Testing
> -------
>
> ? ./gradlew ui:test
> ? ./gradlew ui:lint
>
>
> File Attachments
> ----------------
>
> Screen Shot 2017-10-16 at 6.27.44 PM.png
> https://reviews.apache.org/media/uploaded/files/2017/10/17/7fa71abf-f83e-412f-b554-dc880ccdb25c__Screen_Shot_2017-10-16_at_6.27.44_PM.png
>
>
> Thanks,
>
> Reza Motamedi
>
>
Re: Review Request 63062: Expose list of neighbors in the instance
page
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63062/#review188790
-----------------------------------------------------------
Ship it!
Master (5397013) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Oct. 19, 2017, 10:52 p.m., Reza Motamedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63062/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2017, 10:52 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Kai Huang, and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> # Expose list of neighbors in the instance page
>
> Exposing the list of neighbor task on the host is useful when application tail letencies degrade because of noisy neighbors. Currenlty our service oweners need to jump to the thermos-UI to get this info. This feature will definately help spotting misbehaving neighbors a lot easier.
>
>
> Diffs
> -----
>
> ui/src/main/js/components/TaskNeighbors.js PRE-CREATION
> ui/src/main/js/components/TaskStatus.js b5149182c80b0edcdec88d5c6e24d3015409b0fc
> ui/src/main/js/components/__tests__/TaskNeighbors-test.js PRE-CREATION
> ui/src/main/js/pages/Instance.js c4d625c063b6037ae2ff93e638a3040436515cd5
> ui/src/main/js/utils/Common.js 8f2da7c8a5b44d2ded89a2070ea6ac4bf1fb6ed5
> ui/src/main/sass/components/_instance-page.scss 99204fdfca4441d824c3dfff083f78e1d094b4c9
>
>
> Diff: https://reviews.apache.org/r/63062/diff/4/
>
>
> Testing
> -------
>
> ? ./gradlew ui:test
> ? ./gradlew ui:lint
>
>
> File Attachments
> ----------------
>
> Screen Shot 2017-10-16 at 6.27.44 PM.png
> https://reviews.apache.org/media/uploaded/files/2017/10/17/7fa71abf-f83e-412f-b554-dc880ccdb25c__Screen_Shot_2017-10-16_at_6.27.44_PM.png
> Neighbor list spanning over the entire page.
> https://reviews.apache.org/media/uploaded/files/2017/10/19/38b2d466-991a-4b71-aed7-8b0bada9e678__Screen_Shot_2017-10-19_at_3.48.08_PM.png
>
>
> Thanks,
>
> Reza Motamedi
>
>
Re: Review Request 63062: Expose list of neighbors in the instance
page
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63062/#review188860
-----------------------------------------------------------
This is pushed to master, feel free to close the RB.
- David McLaughlin
On Oct. 19, 2017, 10:52 p.m., Reza Motamedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63062/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2017, 10:52 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Kai Huang, and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> # Expose list of neighbors in the instance page
>
> Exposing the list of neighbor task on the host is useful when application tail letencies degrade because of noisy neighbors. Currenlty our service oweners need to jump to the thermos-UI to get this info. This feature will definately help spotting misbehaving neighbors a lot easier.
>
>
> Diffs
> -----
>
> ui/src/main/js/components/TaskNeighbors.js PRE-CREATION
> ui/src/main/js/components/TaskStatus.js b5149182c80b0edcdec88d5c6e24d3015409b0fc
> ui/src/main/js/components/__tests__/TaskNeighbors-test.js PRE-CREATION
> ui/src/main/js/pages/Instance.js c4d625c063b6037ae2ff93e638a3040436515cd5
> ui/src/main/js/utils/Common.js 8f2da7c8a5b44d2ded89a2070ea6ac4bf1fb6ed5
> ui/src/main/sass/components/_instance-page.scss 99204fdfca4441d824c3dfff083f78e1d094b4c9
>
>
> Diff: https://reviews.apache.org/r/63062/diff/4/
>
>
> Testing
> -------
>
> ? ./gradlew ui:test
> ? ./gradlew ui:lint
>
>
> File Attachments
> ----------------
>
> Screen Shot 2017-10-16 at 6.27.44 PM.png
> https://reviews.apache.org/media/uploaded/files/2017/10/17/7fa71abf-f83e-412f-b554-dc880ccdb25c__Screen_Shot_2017-10-16_at_6.27.44_PM.png
> Neighbor list spanning over the entire page.
> https://reviews.apache.org/media/uploaded/files/2017/10/19/38b2d466-991a-4b71-aed7-8b0bada9e678__Screen_Shot_2017-10-19_at_3.48.08_PM.png
>
>
> Thanks,
>
> Reza Motamedi
>
>
Re: Review Request 63062: Expose list of neighbors in the instance
page
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63062/#review188852
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Kumar Shanmugham
On Oct. 19, 2017, 3:52 p.m., Reza Motamedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63062/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2017, 3:52 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Kai Huang, and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> # Expose list of neighbors in the instance page
>
> Exposing the list of neighbor task on the host is useful when application tail letencies degrade because of noisy neighbors. Currenlty our service oweners need to jump to the thermos-UI to get this info. This feature will definately help spotting misbehaving neighbors a lot easier.
>
>
> Diffs
> -----
>
> ui/src/main/js/components/TaskNeighbors.js PRE-CREATION
> ui/src/main/js/components/TaskStatus.js b5149182c80b0edcdec88d5c6e24d3015409b0fc
> ui/src/main/js/components/__tests__/TaskNeighbors-test.js PRE-CREATION
> ui/src/main/js/pages/Instance.js c4d625c063b6037ae2ff93e638a3040436515cd5
> ui/src/main/js/utils/Common.js 8f2da7c8a5b44d2ded89a2070ea6ac4bf1fb6ed5
> ui/src/main/sass/components/_instance-page.scss 99204fdfca4441d824c3dfff083f78e1d094b4c9
>
>
> Diff: https://reviews.apache.org/r/63062/diff/4/
>
>
> Testing
> -------
>
> ? ./gradlew ui:test
> ? ./gradlew ui:lint
>
>
> File Attachments
> ----------------
>
> Screen Shot 2017-10-16 at 6.27.44 PM.png
> https://reviews.apache.org/media/uploaded/files/2017/10/17/7fa71abf-f83e-412f-b554-dc880ccdb25c__Screen_Shot_2017-10-16_at_6.27.44_PM.png
> Neighbor list spanning over the entire page.
> https://reviews.apache.org/media/uploaded/files/2017/10/19/38b2d466-991a-4b71-aed7-8b0bada9e678__Screen_Shot_2017-10-19_at_3.48.08_PM.png
>
>
> Thanks,
>
> Reza Motamedi
>
>
Re: Review Request 63062: Expose list of neighbors in the instance
page
Posted by Reza Motamedi <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63062/
-----------------------------------------------------------
(Updated Oct. 19, 2017, 10:52 p.m.)
Review request for Aurora, David McLaughlin, Kai Huang, and Santhosh Kumar Shanmugham.
Repository: aurora
Description
-------
# Expose list of neighbors in the instance page
Exposing the list of neighbor task on the host is useful when application tail letencies degrade because of noisy neighbors. Currenlty our service oweners need to jump to the thermos-UI to get this info. This feature will definately help spotting misbehaving neighbors a lot easier.
Diffs
-----
ui/src/main/js/components/TaskNeighbors.js PRE-CREATION
ui/src/main/js/components/TaskStatus.js b5149182c80b0edcdec88d5c6e24d3015409b0fc
ui/src/main/js/components/__tests__/TaskNeighbors-test.js PRE-CREATION
ui/src/main/js/pages/Instance.js c4d625c063b6037ae2ff93e638a3040436515cd5
ui/src/main/js/utils/Common.js 8f2da7c8a5b44d2ded89a2070ea6ac4bf1fb6ed5
ui/src/main/sass/components/_instance-page.scss 99204fdfca4441d824c3dfff083f78e1d094b4c9
Diff: https://reviews.apache.org/r/63062/diff/4/
Testing
-------
? ./gradlew ui:test
? ./gradlew ui:lint
File Attachments (updated)
----------------
Screen Shot 2017-10-16 at 6.27.44 PM.png
https://reviews.apache.org/media/uploaded/files/2017/10/17/7fa71abf-f83e-412f-b554-dc880ccdb25c__Screen_Shot_2017-10-16_at_6.27.44_PM.png
Neighbor list spanning over the entire page.
https://reviews.apache.org/media/uploaded/files/2017/10/19/38b2d466-991a-4b71-aed7-8b0bada9e678__Screen_Shot_2017-10-19_at_3.48.08_PM.png
Thanks,
Reza Motamedi
Re: Review Request 63062: Expose list of neighbors in the instance
page
Posted by Reza Motamedi <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63062/
-----------------------------------------------------------
(Updated Oct. 19, 2017, 10:51 p.m.)
Review request for Aurora, David McLaughlin, Kai Huang, and Santhosh Kumar Shanmugham.
Changes
-------
- Address review feedback.
- Make neighbor list span over the entire page to deal with wrapping neighbor task-keys.
Repository: aurora
Description
-------
# Expose list of neighbors in the instance page
Exposing the list of neighbor task on the host is useful when application tail letencies degrade because of noisy neighbors. Currenlty our service oweners need to jump to the thermos-UI to get this info. This feature will definately help spotting misbehaving neighbors a lot easier.
Diffs
-----
ui/src/main/js/components/TaskNeighbors.js PRE-CREATION
ui/src/main/js/components/TaskStatus.js b5149182c80b0edcdec88d5c6e24d3015409b0fc
ui/src/main/js/components/__tests__/TaskNeighbors-test.js PRE-CREATION
ui/src/main/js/pages/Instance.js c4d625c063b6037ae2ff93e638a3040436515cd5
ui/src/main/js/utils/Common.js 8f2da7c8a5b44d2ded89a2070ea6ac4bf1fb6ed5
ui/src/main/sass/components/_instance-page.scss 99204fdfca4441d824c3dfff083f78e1d094b4c9
Diff: https://reviews.apache.org/r/63062/diff/4/
Testing
-------
? ./gradlew ui:test
? ./gradlew ui:lint
File Attachments (updated)
----------------
Screen Shot 2017-10-16 at 6.27.44 PM.png
https://reviews.apache.org/media/uploaded/files/2017/10/17/7fa71abf-f83e-412f-b554-dc880ccdb25c__Screen_Shot_2017-10-16_at_6.27.44_PM.png
Screen Shot 2017-10-19 at 3.48.08 PM.png
https://reviews.apache.org/media/uploaded/files/2017/10/19/3a0f43dd-de7d-4aff-8668-b6ef36f52009__Screen_Shot_2017-10-19_at_3.48.08_PM.png
Neighbor list spanning over the entire page.
https://reviews.apache.org/media/uploaded/files/2017/10/19/38b2d466-991a-4b71-aed7-8b0bada9e678__Screen_Shot_2017-10-19_at_3.48.08_PM.png
Thanks,
Reza Motamedi
Re: Review Request 63062: Expose list of neighbors in the instance
page
Posted by Reza Motamedi <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63062/
-----------------------------------------------------------
(Updated Oct. 19, 2017, 10:37 p.m.)
Review request for Aurora, David McLaughlin, Kai Huang, and Santhosh Kumar Shanmugham.
Repository: aurora
Description
-------
# Expose list of neighbors in the instance page
Exposing the list of neighbor task on the host is useful when application tail letencies degrade because of noisy neighbors. Currenlty our service oweners need to jump to the thermos-UI to get this info. This feature will definately help spotting misbehaving neighbors a lot easier.
Diffs (updated)
-----
ui/src/main/js/components/TaskNeighbors.js PRE-CREATION
ui/src/main/js/components/TaskStatus.js b5149182c80b0edcdec88d5c6e24d3015409b0fc
ui/src/main/js/components/__tests__/TaskNeighbors-test.js PRE-CREATION
ui/src/main/js/pages/Instance.js c4d625c063b6037ae2ff93e638a3040436515cd5
ui/src/main/js/utils/Common.js 8f2da7c8a5b44d2ded89a2070ea6ac4bf1fb6ed5
ui/src/main/sass/components/_instance-page.scss 99204fdfca4441d824c3dfff083f78e1d094b4c9
Diff: https://reviews.apache.org/r/63062/diff/4/
Changes: https://reviews.apache.org/r/63062/diff/3-4/
Testing
-------
? ./gradlew ui:test
? ./gradlew ui:lint
File Attachments
----------------
Screen Shot 2017-10-16 at 6.27.44 PM.png
https://reviews.apache.org/media/uploaded/files/2017/10/17/7fa71abf-f83e-412f-b554-dc880ccdb25c__Screen_Shot_2017-10-16_at_6.27.44_PM.png
Thanks,
Reza Motamedi
Re: Review Request 63062: Expose list of neighbors in the instance
page
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63062/#review188274
-----------------------------------------------------------
Ship it!
Master (5b72398) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Oct. 17, 2017, 1:34 p.m., Reza Motamedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63062/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 1:34 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Kai Huang, and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> # Expose list of neighbors in the instance page
>
> Exposing the list of neighbor task on the host is useful when application tail letencies degrade because of noisy neighbors. Currenlty our service oweners need to jump to the thermos-UI to get this info. This feature will definately help spotting misbehaving neighbors a lot easier.
>
>
> Diffs
> -----
>
> ui/src/main/js/components/TaskNeighbors.js PRE-CREATION
> ui/src/main/js/components/TaskStatus.js b5149182c80b0edcdec88d5c6e24d3015409b0fc
> ui/src/main/js/components/__tests__/TaskNeighbors-test.js PRE-CREATION
> ui/src/main/js/pages/Instance.js c4d625c063b6037ae2ff93e638a3040436515cd5
> ui/src/main/js/utils/Common.js 8f2da7c8a5b44d2ded89a2070ea6ac4bf1fb6ed5
> ui/src/main/sass/components/_instance-page.scss 99204fdfca4441d824c3dfff083f78e1d094b4c9
>
>
> Diff: https://reviews.apache.org/r/63062/diff/3/
>
>
> Testing
> -------
>
> ? ./gradlew ui:test
> ? ./gradlew ui:lint
>
>
> File Attachments
> ----------------
>
> Screen Shot 2017-10-16 at 6.27.44 PM.png
> https://reviews.apache.org/media/uploaded/files/2017/10/17/7fa71abf-f83e-412f-b554-dc880ccdb25c__Screen_Shot_2017-10-16_at_6.27.44_PM.png
>
>
> Thanks,
>
> Reza Motamedi
>
>
Re: Review Request 63062: Expose list of neighbors in the instance
page
Posted by David McLaughlin <da...@dmclaughlin.com>.
> On Oct. 17, 2017, 7:53 p.m., David McLaughlin wrote:
> > File Attachment: Screen Shot 2017-10-16 at 6.27.44 PM.png - Screen Shot 2017-10-16 at 6.27.44 PM.png
> > <https://reviews.apache.org/r/63062/#fcomment122>
> >
> > I'd also try and find a task with a longer job key and see what it does to the layout. It might make more sense to have this widget as a row spanning the whole width.
>
> Reza Motamedi wrote:
> This happens when task-keys are super long. I made the `div` span the the entire column. However what I think would be better is if we push the state machine a few cells to the right.
> I have seen examples where the TaskId is so long that that it wraps over one line. My suggestion should help with that as well.
The state machine can have messages that also span multiple lines. A 50/50 split is good, I think.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63062/#review188376
-----------------------------------------------------------
On Oct. 19, 2017, 10:37 p.m., Reza Motamedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63062/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2017, 10:37 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Kai Huang, and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> # Expose list of neighbors in the instance page
>
> Exposing the list of neighbor task on the host is useful when application tail letencies degrade because of noisy neighbors. Currenlty our service oweners need to jump to the thermos-UI to get this info. This feature will definately help spotting misbehaving neighbors a lot easier.
>
>
> Diffs
> -----
>
> ui/src/main/js/components/TaskNeighbors.js PRE-CREATION
> ui/src/main/js/components/TaskStatus.js b5149182c80b0edcdec88d5c6e24d3015409b0fc
> ui/src/main/js/components/__tests__/TaskNeighbors-test.js PRE-CREATION
> ui/src/main/js/pages/Instance.js c4d625c063b6037ae2ff93e638a3040436515cd5
> ui/src/main/js/utils/Common.js 8f2da7c8a5b44d2ded89a2070ea6ac4bf1fb6ed5
> ui/src/main/sass/components/_instance-page.scss 99204fdfca4441d824c3dfff083f78e1d094b4c9
>
>
> Diff: https://reviews.apache.org/r/63062/diff/4/
>
>
> Testing
> -------
>
> ? ./gradlew ui:test
> ? ./gradlew ui:lint
>
>
> File Attachments
> ----------------
>
> Screen Shot 2017-10-16 at 6.27.44 PM.png
> https://reviews.apache.org/media/uploaded/files/2017/10/17/7fa71abf-f83e-412f-b554-dc880ccdb25c__Screen_Shot_2017-10-16_at_6.27.44_PM.png
>
>
> Thanks,
>
> Reza Motamedi
>
>
Re: Review Request 63062: Expose list of neighbors in the instance
page
Posted by Reza Motamedi <re...@gmail.com>.
> On Oct. 17, 2017, 7:53 p.m., David McLaughlin wrote:
> > File Attachment: Screen Shot 2017-10-16 at 6.27.44 PM.png - Screen Shot 2017-10-16 at 6.27.44 PM.png
> > <https://reviews.apache.org/r/63062/#fcomment121>
> >
> > I'd also try and find a task with a longer job key and see what it does to the layout. It might make more sense to have this widget as a row spanning the whole width.
This happens when task-keys are super long. I made the `div` span the the entire column. However what I think would be better is if we push the state machine a few cells to the right.
I have seen examples where the TaskId is so long that that it wraps over one line. My suggestion should help with that as well.
- Reza
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63062/#review188376
-----------------------------------------------------------
On Oct. 19, 2017, 10:37 p.m., Reza Motamedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63062/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2017, 10:37 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Kai Huang, and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> # Expose list of neighbors in the instance page
>
> Exposing the list of neighbor task on the host is useful when application tail letencies degrade because of noisy neighbors. Currenlty our service oweners need to jump to the thermos-UI to get this info. This feature will definately help spotting misbehaving neighbors a lot easier.
>
>
> Diffs
> -----
>
> ui/src/main/js/components/TaskNeighbors.js PRE-CREATION
> ui/src/main/js/components/TaskStatus.js b5149182c80b0edcdec88d5c6e24d3015409b0fc
> ui/src/main/js/components/__tests__/TaskNeighbors-test.js PRE-CREATION
> ui/src/main/js/pages/Instance.js c4d625c063b6037ae2ff93e638a3040436515cd5
> ui/src/main/js/utils/Common.js 8f2da7c8a5b44d2ded89a2070ea6ac4bf1fb6ed5
> ui/src/main/sass/components/_instance-page.scss 99204fdfca4441d824c3dfff083f78e1d094b4c9
>
>
> Diff: https://reviews.apache.org/r/63062/diff/4/
>
>
> Testing
> -------
>
> ? ./gradlew ui:test
> ? ./gradlew ui:lint
>
>
> File Attachments
> ----------------
>
> Screen Shot 2017-10-16 at 6.27.44 PM.png
> https://reviews.apache.org/media/uploaded/files/2017/10/17/7fa71abf-f83e-412f-b554-dc880ccdb25c__Screen_Shot_2017-10-16_at_6.27.44_PM.png
>
>
> Thanks,
>
> Reza Motamedi
>
>
Re: Review Request 63062: Expose list of neighbors in the instance
page
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63062/#review188376
-----------------------------------------------------------
Ship it!
LGTM with comments addressed.
File Attachment: Screen Shot 2017-10-16 at 6.27.44 PM.png - Screen Shot 2017-10-16 at 6.27.44 PM.png
<https://reviews.apache.org//r/63062/#fcomment119>
I'd also try and find a task with a longer job key and see what it does to the layout. It might make more sense to have this widget as a row spanning the whole width.
- David McLaughlin
On Oct. 17, 2017, 5:34 a.m., Reza Motamedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63062/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 5:34 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Kai Huang, and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> # Expose list of neighbors in the instance page
>
> Exposing the list of neighbor task on the host is useful when application tail letencies degrade because of noisy neighbors. Currenlty our service oweners need to jump to the thermos-UI to get this info. This feature will definately help spotting misbehaving neighbors a lot easier.
>
>
> Diffs
> -----
>
> ui/src/main/js/components/TaskNeighbors.js PRE-CREATION
> ui/src/main/js/components/TaskStatus.js b5149182c80b0edcdec88d5c6e24d3015409b0fc
> ui/src/main/js/components/__tests__/TaskNeighbors-test.js PRE-CREATION
> ui/src/main/js/pages/Instance.js c4d625c063b6037ae2ff93e638a3040436515cd5
> ui/src/main/js/utils/Common.js 8f2da7c8a5b44d2ded89a2070ea6ac4bf1fb6ed5
> ui/src/main/sass/components/_instance-page.scss 99204fdfca4441d824c3dfff083f78e1d094b4c9
>
>
> Diff: https://reviews.apache.org/r/63062/diff/3/
>
>
> Testing
> -------
>
> ? ./gradlew ui:test
> ? ./gradlew ui:lint
>
>
> File Attachments
> ----------------
>
> Screen Shot 2017-10-16 at 6.27.44 PM.png
> https://reviews.apache.org/media/uploaded/files/2017/10/17/7fa71abf-f83e-412f-b554-dc880ccdb25c__Screen_Shot_2017-10-16_at_6.27.44_PM.png
>
>
> Thanks,
>
> Reza Motamedi
>
>
Re: Review Request 63062: Expose list of neighbors in the instance
page
Posted by Kai Huang <te...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63062/#review188341
-----------------------------------------------------------
Fix it, then Ship it!
LGTM
ui/src/main/sass/components/_instance-page.scss
Lines 31 (patched)
<https://reviews.apache.org/r/63062/#comment265326>
s/taskkey/task-key/
or task-instance-id
- Kai Huang
On Oct. 17, 2017, 5:34 a.m., Reza Motamedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63062/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 5:34 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Kai Huang, and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> # Expose list of neighbors in the instance page
>
> Exposing the list of neighbor task on the host is useful when application tail letencies degrade because of noisy neighbors. Currenlty our service oweners need to jump to the thermos-UI to get this info. This feature will definately help spotting misbehaving neighbors a lot easier.
>
>
> Diffs
> -----
>
> ui/src/main/js/components/TaskNeighbors.js PRE-CREATION
> ui/src/main/js/components/TaskStatus.js b5149182c80b0edcdec88d5c6e24d3015409b0fc
> ui/src/main/js/components/__tests__/TaskNeighbors-test.js PRE-CREATION
> ui/src/main/js/pages/Instance.js c4d625c063b6037ae2ff93e638a3040436515cd5
> ui/src/main/js/utils/Common.js 8f2da7c8a5b44d2ded89a2070ea6ac4bf1fb6ed5
> ui/src/main/sass/components/_instance-page.scss 99204fdfca4441d824c3dfff083f78e1d094b4c9
>
>
> Diff: https://reviews.apache.org/r/63062/diff/3/
>
>
> Testing
> -------
>
> ? ./gradlew ui:test
> ? ./gradlew ui:lint
>
>
> File Attachments
> ----------------
>
> Screen Shot 2017-10-16 at 6.27.44 PM.png
> https://reviews.apache.org/media/uploaded/files/2017/10/17/7fa71abf-f83e-412f-b554-dc880ccdb25c__Screen_Shot_2017-10-16_at_6.27.44_PM.png
>
>
> Thanks,
>
> Reza Motamedi
>
>
Re: Review Request 63062: Expose list of neighbors in the instance
page
Posted by Reza Motamedi <re...@gmail.com>.
> On Oct. 17, 2017, 7:50 p.m., Santhosh Kumar Shanmugham wrote:
> > File Attachment: Screen Shot 2017-10-16 at 6.27.44 PM.png - Screen Shot 2017-10-16 at 6.27.44 PM.png
> > <https://reviews.apache.org/r/63062/#fcomment120>
> >
> > Wonder if we need to paginate this? Think the most neighbors I have seen is ~20.
Mybe we can add that later if we start seeing that is distracting. I don't think in reality this is going to be very long.
> On Oct. 17, 2017, 7:50 p.m., Santhosh Kumar Shanmugham wrote:
> > ui/src/main/js/components/TaskNeighbors.js
> > Lines 21 (patched)
> > <https://reviews.apache.org/r/63062/diff/3/?file=1859686#file1859686line21>
> >
> > `isNullyOrEmpty` already checks if the collection is empty? In which case `tasks.length === 0` is redudant.
Good catch! thanks :)
- Reza
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63062/#review188371
-----------------------------------------------------------
On Oct. 19, 2017, 10:37 p.m., Reza Motamedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63062/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2017, 10:37 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Kai Huang, and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> # Expose list of neighbors in the instance page
>
> Exposing the list of neighbor task on the host is useful when application tail letencies degrade because of noisy neighbors. Currenlty our service oweners need to jump to the thermos-UI to get this info. This feature will definately help spotting misbehaving neighbors a lot easier.
>
>
> Diffs
> -----
>
> ui/src/main/js/components/TaskNeighbors.js PRE-CREATION
> ui/src/main/js/components/TaskStatus.js b5149182c80b0edcdec88d5c6e24d3015409b0fc
> ui/src/main/js/components/__tests__/TaskNeighbors-test.js PRE-CREATION
> ui/src/main/js/pages/Instance.js c4d625c063b6037ae2ff93e638a3040436515cd5
> ui/src/main/js/utils/Common.js 8f2da7c8a5b44d2ded89a2070ea6ac4bf1fb6ed5
> ui/src/main/sass/components/_instance-page.scss 99204fdfca4441d824c3dfff083f78e1d094b4c9
>
>
> Diff: https://reviews.apache.org/r/63062/diff/4/
>
>
> Testing
> -------
>
> ? ./gradlew ui:test
> ? ./gradlew ui:lint
>
>
> File Attachments
> ----------------
>
> Screen Shot 2017-10-16 at 6.27.44 PM.png
> https://reviews.apache.org/media/uploaded/files/2017/10/17/7fa71abf-f83e-412f-b554-dc880ccdb25c__Screen_Shot_2017-10-16_at_6.27.44_PM.png
>
>
> Thanks,
>
> Reza Motamedi
>
>
Re: Review Request 63062: Expose list of neighbors in the instance
page
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63062/#review188371
-----------------------------------------------------------
Ship it!
LGTM. Improvement suggested.
File Attachment: Screen Shot 2017-10-16 at 6.27.44 PM.png - Screen Shot 2017-10-16 at 6.27.44 PM.png
<https://reviews.apache.org//r/63062/#fcomment118>
Wonder if we need to paginate this? Think the most neighbors I have seen is ~20.
ui/src/main/js/components/TaskNeighbors.js
Lines 21 (patched)
<https://reviews.apache.org/r/63062/#comment265361>
`isNullyOrEmpty` already checks if the collection is empty? In which case `tasks.length === 0` is redudant.
- Santhosh Kumar Shanmugham
On Oct. 16, 2017, 10:34 p.m., Reza Motamedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63062/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2017, 10:34 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Kai Huang, and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> # Expose list of neighbors in the instance page
>
> Exposing the list of neighbor task on the host is useful when application tail letencies degrade because of noisy neighbors. Currenlty our service oweners need to jump to the thermos-UI to get this info. This feature will definately help spotting misbehaving neighbors a lot easier.
>
>
> Diffs
> -----
>
> ui/src/main/js/components/TaskNeighbors.js PRE-CREATION
> ui/src/main/js/components/TaskStatus.js b5149182c80b0edcdec88d5c6e24d3015409b0fc
> ui/src/main/js/components/__tests__/TaskNeighbors-test.js PRE-CREATION
> ui/src/main/js/pages/Instance.js c4d625c063b6037ae2ff93e638a3040436515cd5
> ui/src/main/js/utils/Common.js 8f2da7c8a5b44d2ded89a2070ea6ac4bf1fb6ed5
> ui/src/main/sass/components/_instance-page.scss 99204fdfca4441d824c3dfff083f78e1d094b4c9
>
>
> Diff: https://reviews.apache.org/r/63062/diff/3/
>
>
> Testing
> -------
>
> ? ./gradlew ui:test
> ? ./gradlew ui:lint
>
>
> File Attachments
> ----------------
>
> Screen Shot 2017-10-16 at 6.27.44 PM.png
> https://reviews.apache.org/media/uploaded/files/2017/10/17/7fa71abf-f83e-412f-b554-dc880ccdb25c__Screen_Shot_2017-10-16_at_6.27.44_PM.png
>
>
> Thanks,
>
> Reza Motamedi
>
>
Re: Review Request 63062: Expose list of neighbors in the instance
page
Posted by Reza Motamedi <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63062/
-----------------------------------------------------------
(Updated Oct. 17, 2017, 5:34 a.m.)
Review request for Aurora, David McLaughlin, Kai Huang, and Santhosh Kumar Shanmugham.
Summary (updated)
-----------------
Expose list of neighbors in the instance page
Repository: aurora
Description
-------
# Expose list of neighbors in the instance page
Exposing the list of neighbor task on the host is useful when application tail letencies degrade because of noisy neighbors. Currenlty our service oweners need to jump to the thermos-UI to get this info. This feature will definately help spotting misbehaving neighbors a lot easier.
Diffs (updated)
-----
ui/src/main/js/components/TaskNeighbors.js PRE-CREATION
ui/src/main/js/components/TaskStatus.js b5149182c80b0edcdec88d5c6e24d3015409b0fc
ui/src/main/js/components/__tests__/TaskNeighbors-test.js PRE-CREATION
ui/src/main/js/pages/Instance.js c4d625c063b6037ae2ff93e638a3040436515cd5
ui/src/main/js/utils/Common.js 8f2da7c8a5b44d2ded89a2070ea6ac4bf1fb6ed5
ui/src/main/sass/components/_instance-page.scss 99204fdfca4441d824c3dfff083f78e1d094b4c9
Diff: https://reviews.apache.org/r/63062/diff/3/
Changes: https://reviews.apache.org/r/63062/diff/2-3/
Testing
-------
? ./gradlew ui:test
? ./gradlew ui:lint
File Attachments
----------------
Screen Shot 2017-10-16 at 6.27.44 PM.png
https://reviews.apache.org/media/uploaded/files/2017/10/17/7fa71abf-f83e-412f-b554-dc880ccdb25c__Screen_Shot_2017-10-16_at_6.27.44_PM.png
Thanks,
Reza Motamedi
Re: Review Request 63062: Adding test for neighbor panel in UI
Posted by Reza Motamedi <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63062/
-----------------------------------------------------------
(Updated Oct. 17, 2017, 5:19 a.m.)
Review request for Aurora, David McLaughlin, Kai Huang, and Santhosh Kumar Shanmugham.
Repository: aurora
Description
-------
# Expose list of neighbors in the instance page
Exposing the list of neighbor task on the host is useful when application tail letencies degrade because of noisy neighbors. Currenlty our service oweners need to jump to the thermos-UI to get this info. This feature will definately help spotting misbehaving neighbors a lot easier.
Diffs (updated)
-----
ui/src/main/js/components/TaskNeighbors.js PRE-CREATION
ui/src/main/js/components/TaskStatus.js b5149182c80b0edcdec88d5c6e24d3015409b0fc
ui/src/main/js/components/__tests__/TaskNeighbors-test.js PRE-CREATION
ui/src/main/js/pages/Instance.js c4d625c063b6037ae2ff93e638a3040436515cd5
ui/src/main/js/utils/Common.js 8f2da7c8a5b44d2ded89a2070ea6ac4bf1fb6ed5
ui/src/main/sass/components/_instance-page.scss 99204fdfca4441d824c3dfff083f78e1d094b4c9
Diff: https://reviews.apache.org/r/63062/diff/2/
Changes: https://reviews.apache.org/r/63062/diff/1-2/
Testing
-------
? ./gradlew ui:test
? ./gradlew ui:lint
File Attachments
----------------
Screen Shot 2017-10-16 at 6.27.44 PM.png
https://reviews.apache.org/media/uploaded/files/2017/10/17/7fa71abf-f83e-412f-b554-dc880ccdb25c__Screen_Shot_2017-10-16_at_6.27.44_PM.png
Thanks,
Reza Motamedi