You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/12/16 16:13:22 UTC
[GitHub] [ignite] antkr opened a new pull request #8581: IGNITE-11110 fixed stop case with collision SPI enabled.
antkr opened a new pull request #8581:
URL: https://github.com/apache/ignite/pull/8581
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] asfgit closed pull request #8581: IGNITE-11110 fixed stop case with collision SPI enabled.
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #8581:
URL: https://github.com/apache/ignite/pull/8581
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] antkr commented on a change in pull request #8581: IGNITE-11110 fixed stop case with collision SPI enabled.
Posted by GitBox <gi...@apache.org>.
antkr commented on a change in pull request #8581:
URL: https://github.com/apache/ignite/pull/8581#discussion_r548018542
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/job/GridJobProcessor.java
##########
@@ -377,7 +377,10 @@ public GridJobProcessor(GridKernalContext ctx) {
/** {@inheritDoc} */
@Override public void stop(boolean cancel) {
// Clear collections.
- activeJobs.clear();
+ if (jobAlwaysActivate)
+ activeJobs.clear();
Review comment:
Makes sense, pushed an update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] alamar commented on a change in pull request #8581: IGNITE-11110 fixed stop case with collision SPI enabled.
Posted by GitBox <gi...@apache.org>.
alamar commented on a change in pull request #8581:
URL: https://github.com/apache/ignite/pull/8581#discussion_r546734515
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/job/GridJobProcessor.java
##########
@@ -377,7 +377,10 @@ public GridJobProcessor(GridKernalContext ctx) {
/** {@inheritDoc} */
@Override public void stop(boolean cancel) {
// Clear collections.
- activeJobs.clear();
+ if (jobAlwaysActivate)
+ activeJobs.clear();
Review comment:
Can we please put this logic in a method, do not use clear in both cases?
I.e. line 309 and stop() should use the same logic to create a fresh map.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org