[GitHub] [hudi] wulei0302 commented on a diff in pull request #5627: [HUDI-3350][HUDI-3351] Rebase Record combining semantic into `HoodieRecordCombiningEngine`

[GitBox <gi...@apache.org>]

wulei0302 commented on code in PR #5627:
URL: https://github.com/apache/hudi/pull/5627#discussion_r895332836


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieCompactionConfig.java:
##########
@@ -234,6 +235,12 @@ public class HoodieCompactionConfig extends HoodieConfig {
           + "the record payload class to merge records in the log against each other, merge again with the base file and "
           + "produce the final record to be written after compaction.");
 
+  public static final ConfigProperty<String> COMBINE_ENGINE_CLASS_NAME = ConfigProperty
+      .key("hoodie.compaction.combine.engine.class")
+      .defaultValue(HoodieAvroRecordCombiningEngine.class.getName())
+      .withDocumentation("Combine engine class to use for performing compactions, i.e merge delta logs with current base file and then "

Review Comment:
   Yeah,I will make adjustments, Thank you for your advice.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org