You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by uce <gi...@git.apache.org> on 2016/03/01 13:35:50 UTC
[GitHub] flink pull request: [FLINK-3556] [runtime] Remove false check in H...
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/1749
[FLINK-3556] [runtime] Remove false check in HA blob store configuration
If you use the `RocksDBStateBackend` and configure HA w/o setting the state backend to `filesystem`, restoring your job will fail, because the BLOBs are not persisted. The really ugly part is that this does not log a warning or anything. I'm leaning towards making this a release blocker, but it can also be postponed to `1.0.1`, if that follows very soon.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/uce/flink 3556-blob
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1749.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1749
----
commit 3b2b6a823c6b2931d9e95d1c8f1f759af2dd436a
Author: Ufuk Celebi <uc...@apache.org>
Date: 2016-03-01T11:23:31Z
[FLINK-3556] [runtime] Remove false check in HA blob store configuration
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3556] [runtime] Remove false check in H...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1749#issuecomment-190730402
+1 for merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3556] [runtime] Remove false check in H...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1749#issuecomment-190733432
OK, going to merge to master and release-1.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3556] [runtime] Remove false check in H...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1749#issuecomment-190727944
PS I had a local Travis build with this (1st commit), which succeeded https://travis-ci.org/uce/flink/builds/112830163 and the blob and recovery tests succeed on my local laptop with the latest commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3556] [runtime] Remove false check in H...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1749#issuecomment-190722183
Changes look good to me. Good catch @uce :-) +1 for merging.
One minor thing: We check that the configuration contains the `ZOOKEEPER_RECOVERY_PATH` and then give the configuration to the `FileSystemBlobStore`. Wouldn't it make more sense to directly pass in the value of `ZOOKEEPER_RECOVERY_PATH` or do the checking of the correctness of the value in the `FileSystemBlobStore`? If we pass the configuration, then we don't actually know, which values will be used internally. This would untie the `BlobServer` and the `FileSystemBlobStore` a bit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3556] [runtime] Remove false check in H...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1749#issuecomment-190727002
Thanks Till! The check was duplicated in `BlobServer` and `FileSystemBlobStore`. Now only config is passed and it's the responsibility of `FileSystemBlobStore` to construct itself correctly or fail.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3556] [runtime] Remove false check in H...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1749
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---