You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@activemq.apache.org by jb...@apache.org on 2021/07/06 19:59:48 UTC
[activemq-artemis] branch main updated: ARTEMIS-3327 Removing
unecessary block operation on journal append record
This is an automated email from the ASF dual-hosted git repository.
jbertram pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git
The following commit(s) were added to refs/heads/main by this push:
new 5c051e9 ARTEMIS-3327 Removing unecessary block operation on journal append record
new d800957 This closes #3644
5c051e9 is described below
commit 5c051e98329eb69a1d923ce20c689d2aee065348
Author: Clebert Suconic <cl...@apache.org>
AuthorDate: Tue Jul 6 14:19:11 2021 -0400
ARTEMIS-3327 Removing unecessary block operation on journal append record
---
.../org/apache/activemq/artemis/core/journal/impl/JournalImpl.java | 6 ------
1 file changed, 6 deletions(-)
diff --git a/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java b/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java
index ed6f38a..8509db6 100644
--- a/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java
+++ b/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java
@@ -935,7 +935,6 @@ public class JournalImpl extends JournalBase implements TestableJournal, Journal
throw ActiveMQJournalBundle.BUNDLE.recordLargerThanStoreMax(addRecordEncodeSize, maxRecordSize);
}
- final SimpleFuture<Boolean> result = newSyncAndCallbackResult(sync, callback);
appendExecutor.execute(new Runnable() {
@Override
public void run() {
@@ -952,12 +951,9 @@ public class JournalImpl extends JournalBase implements TestableJournal, Journal
", usedFile = " +
usedFile);
}
- result.set(true);
} catch (ActiveMQShutdownException e) {
- result.fail(e);
logger.error("appendAddRecord:" + e, e);
} catch (Throwable e) {
- result.fail(e);
setErrorCondition(callback, null, e);
logger.error("appendAddRecord::" + e, e);
} finally {
@@ -965,8 +961,6 @@ public class JournalImpl extends JournalBase implements TestableJournal, Journal
}
}
});
-
- result.get();
}