You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/10/09 12:26:45 UTC
[GitHub] eolivelli commented on a change in pull request #1747: (WIP) Set
ConnectionExpired Listener to MetadataClientDriver in AR
eolivelli commented on a change in pull request #1747: (WIP) Set ConnectionExpired Listener to MetadataClientDriver in AR
URL: https://github.com/apache/bookkeeper/pull/1747#discussion_r223677405
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/MetadataClientDriver.java
##########
@@ -84,4 +84,23 @@ LedgerManagerFactory getLedgerManagerFactory()
@Override
void close();
+ /**
+ * Listener on listening the metadata client connection expiry event.
+ */
+ @FunctionalInterface
Review comment:
I wonder if we can have a more neutral term. This is a ZK very specific concept
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services