You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by sethah <gi...@git.apache.org> on 2017/10/27 23:05:13 UTC

[GitHub] spark pull request #18610: [SPARK-21386] ML LinearRegression supports warm s...

Github user sethah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18610#discussion_r147532256
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
    @@ -226,6 +246,12 @@ class LinearRegression @Since("1.3.0") (@Since("1.3.0") override val uid: String
     
         if (($(solver) == Auto &&
           numFeatures <= WeightedLeastSquares.MAX_NUM_FEATURES) || $(solver) == Normal) {
    +
    +      if (isSet(initialModel)) {
    +        logWarning("Initial model will be ignored if fitting by normal solver. " +
    --- End diff --
    
    I disagree. Normal solver provides an exact solution, so it is harmless to ignore the initial model. I don't see a reason to do anything more than log a warning.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org