You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/13 00:02:26 UTC

[GitHub] [shardingsphere] iofit opened a new pull request, #21537: Add unit tests to cover CuratorZookeeperRepository.getNumChildren method

iofit opened a new pull request, #21537:
URL: https://github.com/apache/shardingsphere/pull/21537

   Fixes #21434.
   
   Changes proposed in this pull request:
     - Added test to return num of children set with multiple argument constructor
     - Added test to return zero when using default constructor
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [X] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [X] I have self-reviewed the commit code.
   - [X] I have (or in comment I request) added corresponding labels for the pull request.
   - [X] I have passed maven check locally : `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
   - [X] I have made corresponding changes to the documentation.
   - [X] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] codecov-commenter commented on pull request #21537: Add unit tests to cover CuratorZookeeperRepository.getNumChildren method

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #21537:
URL: https://github.com/apache/shardingsphere/pull/21537#issuecomment-1279010870

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/21537?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#21537](https://codecov.io/gh/apache/shardingsphere/pull/21537?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cdd58d0) into [master](https://codecov.io/gh/apache/shardingsphere/commit/63dbcdb356945394d5edaa55cdb9432663b5079d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (63dbcdb) will **increase** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #21537   +/-   ##
   =========================================
     Coverage     61.16%   61.16%           
   - Complexity     2508     2509    +1     
   =========================================
     Files          4109     4109           
     Lines         57118    57118           
     Branches       7559     7559           
   =========================================
   + Hits          34935    34937    +2     
   + Misses        19251    19248    -3     
   - Partials       2932     2933    +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/21537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../cluster/zookeeper/CuratorZookeeperRepository.java](https://codecov.io/gh/apache/shardingsphere/pull/21537/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL2NsdXN0ZXIvcmVwb3NpdG9yeS9wcm92aWRlci96b29rZWVwZXItY3VyYXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbW9kZS9yZXBvc2l0b3J5L2NsdXN0ZXIvem9va2VlcGVyL0N1cmF0b3Jab29rZWVwZXJSZXBvc2l0b3J5LmphdmE=) | `38.58% <0.00%> (+1.08%)` | :arrow_up: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] terrymanu merged pull request #21537: Add unit tests to cover CuratorZookeeperRepository.getNumChildren method

Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #21537:
URL: https://github.com/apache/shardingsphere/pull/21537


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org