You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/03 22:24:50 UTC
[GitHub] [airflow] anitakar opened a new pull request #10142: Disable editing DAG in Airflow UI
anitakar opened a new pull request #10142:
URL: https://github.com/apache/airflow/pull/10142
Airflow does not modify underlaying DAG file only model.
Changes are resetted next time DAG is reloaded.
closes: #10133
related: #10133
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil closed pull request #10142: Disable editing DAG in Airflow UI
Posted by GitBox <gi...@apache.org>.
kaxil closed pull request #10142:
URL: https://github.com/apache/airflow/pull/10142
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10142: Disable editing DAG in Airflow UI
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10142:
URL: https://github.com/apache/airflow/pull/10142#issuecomment-668739882
Hemm there are some issues for static checks - I will cherry-pick tomorrow some of the recent changes from master and try to see if this is something that happens in the latest v1-10-test. However I strongly recommend to rebase it and to 'v1-10-stable' - this is usually how PRs are done to 1.10 (we use v1-10-test to cherry-pick stuff and it break more often than not while we are cherry-picking it).
One question - is this something that is also present in the RBAC UI ? because if so, we should also make a PR against master and cherry-pick it to the RBAC UI?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] anitakar commented on pull request #10142: Disable editing DAG in Airflow UI
Posted by GitBox <gi...@apache.org>.
anitakar commented on pull request #10142:
URL: https://github.com/apache/airflow/pull/10142#issuecomment-671411907
> Hemm there are some issues for static checks - I will cherry-pick tomorrow some of the recent changes from master and try to see if this is something that happens in the latest v1-10-test. However I strongly recommend to rebase it and to 'v1-10-stable' - this is usually how PRs are done to 1.10 (we use v1-10-test to cherry-pick stuff and it break more often than not while we are cherry-picking it).
>
> One question - is this something that is also present in the RBAC UI ? because if so, we should also make a PR against master and cherry-pick it to the RBAC UI?
I did not know how to rebase this change on another branch so i have created another change: https://github.com/apache/airflow/pull/10277
Those fields are already not editable in master.
I still need to check whether they are editable on 1.10 branch in rbac ui.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org