You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/22 13:17:37 UTC

[GitHub] [flink] dawidwys opened a new pull request #10925: [FLINK-15690][core][configuration] Enable configuring ExecutionConfig & CheckpointConfig from flink-conf.yaml

dawidwys opened a new pull request #10925:  [FLINK-15690][core][configuration] Enable configuring ExecutionConfig & CheckpointConfig from flink-conf.yaml
URL: https://github.com/apache/flink/pull/10925
 
 
   ## What is the purpose of the change
   
   * Add a `configure` method to `ExecutionEnvironment` similar to the one in `StreamExecutionEnvironment`
   * Pass configuration read from `flink-conf.yaml` to `configure` method on instantiation of `(Stream)ExecutionEnvironment`
   * Pass configuration from `BatchTableEnvironment` to the underlying `ExecutionEnvironment`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**yes** / no)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (**yes** / no / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (**yes** / no)
     - If yes, how is the feature documented? (not applicable / docs / **JavaDocs** / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] dawidwys commented on a change in pull request #10925: [FLINK-15690][core][configuration] Enable configuring ExecutionConfig & CheckpointConfig from flink-conf.yaml

Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #10925:  [FLINK-15690][core][configuration] Enable configuring ExecutionConfig & CheckpointConfig from flink-conf.yaml
URL: https://github.com/apache/flink/pull/10925#discussion_r369576607
 
 

 ##########
 File path: flink-core/src/main/java/org/apache/flink/api/common/cache/DistributedCache.java
 ##########
 @@ -183,6 +187,33 @@ public static void writeFileInfoToConfig(String name, DistributedCacheEntry e, C
 		return cacheFiles.entrySet();
 	}
 
+	/**
 
 Review comment:
   Those changes are here because I moved the parsing logic of the `CachedFiles` from `StreamExecutionEnvironment` here so I can reuse it in both `ExecutionEnvironment` & `StreamExecutionEnvironment`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10925: [FLINK-15690][core][configuration] Enable configuring ExecutionConfig & CheckpointConfig from flink-conf.yaml

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10925:  [FLINK-15690][core][configuration] Enable configuring ExecutionConfig & CheckpointConfig from flink-conf.yaml
URL: https://github.com/apache/flink/pull/10925#issuecomment-577178286
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit acfe335a939a46b76b565bce36ef94c0da9c961a (Wed Jan 22 13:20:48 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10925: [FLINK-15690][core][configuration] Enable configuring ExecutionConfig & CheckpointConfig from flink-conf.yaml

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10925:  [FLINK-15690][core][configuration] Enable configuring ExecutionConfig & CheckpointConfig from flink-conf.yaml
URL: https://github.com/apache/flink/pull/10925#issuecomment-577208199
 
 
   <!--
   Meta data
   Hash:fef1d1a01563530a905771e1ef4b23879190be76 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:fef1d1a01563530a905771e1ef4b23879190be76
   -->
   ## CI report:
   
   * fef1d1a01563530a905771e1ef4b23879190be76 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] aljoscha commented on a change in pull request #10925: [FLINK-15690][core][configuration] Enable configuring ExecutionConfig & CheckpointConfig from flink-conf.yaml

Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #10925:  [FLINK-15690][core][configuration] Enable configuring ExecutionConfig & CheckpointConfig from flink-conf.yaml
URL: https://github.com/apache/flink/pull/10925#discussion_r369572659
 
 

 ##########
 File path: flink-scala/src/main/scala/org/apache/flink/api/scala/ExecutionEnvironment.scala
 ##########
 @@ -192,6 +192,22 @@ class ExecutionEnvironment(javaEnv: JavaEnv) {
     javaEnv.registerType(typeClass)
   }
 
+  /**
+   * Sets all relevant options contained in the [[ReadableConfig]] such as e.g.
+   * [[org.apache.flink.configuration.PipelineOptions#CACHED_FILES]]. It will reconfigure
+   * [[ExecutionEnvironment]] and [[ExecutionConfig]].
+   *
+   * It will change the value of a setting only if a corresponding option was set in the
+   * `configuration`. If a key is not present, the current value of a field will remain
+   * untouched.
+   *
+   * @param configuration a configuration to read the values from
+   * @param classLoader   a class loader to use when loading classes
+   */
+  def configure(configuration: ReadableConfig, classLoader: ClassLoader): Unit = {
 
 Review comment:
   `PublicEvolving` annotation?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] aljoscha commented on a change in pull request #10925: [FLINK-15690][core][configuration] Enable configuring ExecutionConfig & CheckpointConfig from flink-conf.yaml

Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #10925:  [FLINK-15690][core][configuration] Enable configuring ExecutionConfig & CheckpointConfig from flink-conf.yaml
URL: https://github.com/apache/flink/pull/10925#discussion_r369573440
 
 

 ##########
 File path: flink-core/src/main/java/org/apache/flink/api/common/cache/DistributedCache.java
 ##########
 @@ -183,6 +187,33 @@ public static void writeFileInfoToConfig(String name, DistributedCacheEntry e, C
 		return cacheFiles.entrySet();
 	}
 
+	/**
 
 Review comment:
   Are the seemingly unrelated changed to cached file configuration in this commit because you noticed there was something wrong with it? Might still make sense to split it into a separate commit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] dawidwys closed pull request #10925: [FLINK-15690][core][configuration] Enable configuring ExecutionConfig & CheckpointConfig from flink-conf.yaml

Posted by GitBox <gi...@apache.org>.
dawidwys closed pull request #10925:  [FLINK-15690][core][configuration] Enable configuring ExecutionConfig & CheckpointConfig from flink-conf.yaml
URL: https://github.com/apache/flink/pull/10925
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10925: [FLINK-15690][core][configuration] Enable configuring ExecutionConfig & CheckpointConfig from flink-conf.yaml

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10925:  [FLINK-15690][core][configuration] Enable configuring ExecutionConfig & CheckpointConfig from flink-conf.yaml
URL: https://github.com/apache/flink/pull/10925#issuecomment-577208199
 
 
   <!--
   Meta data
   Hash:fef1d1a01563530a905771e1ef4b23879190be76 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/145567838 TriggerType:PUSH TriggerID:fef1d1a01563530a905771e1ef4b23879190be76
   Hash:fef1d1a01563530a905771e1ef4b23879190be76 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4557 TriggerType:PUSH TriggerID:fef1d1a01563530a905771e1ef4b23879190be76
   -->
   ## CI report:
   
   * fef1d1a01563530a905771e1ef4b23879190be76 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/145567838) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4557) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] dawidwys commented on issue #10925: [FLINK-15690][core][configuration] Enable configuring ExecutionConfig & CheckpointConfig from flink-conf.yaml

Posted by GitBox <gi...@apache.org>.
dawidwys commented on issue #10925:  [FLINK-15690][core][configuration] Enable configuring ExecutionConfig & CheckpointConfig from flink-conf.yaml
URL: https://github.com/apache/flink/pull/10925#issuecomment-577177191
 
 
   Could you have a look @aljoscha @kl0u ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10925: [FLINK-15690][core][configuration] Enable configuring ExecutionConfig & CheckpointConfig from flink-conf.yaml

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10925:  [FLINK-15690][core][configuration] Enable configuring ExecutionConfig & CheckpointConfig from flink-conf.yaml
URL: https://github.com/apache/flink/pull/10925#issuecomment-577208199
 
 
   <!--
   Meta data
   Hash:fef1d1a01563530a905771e1ef4b23879190be76 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145567838 TriggerType:PUSH TriggerID:fef1d1a01563530a905771e1ef4b23879190be76
   Hash:fef1d1a01563530a905771e1ef4b23879190be76 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4557 TriggerType:PUSH TriggerID:fef1d1a01563530a905771e1ef4b23879190be76
   -->
   ## CI report:
   
   * fef1d1a01563530a905771e1ef4b23879190be76 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145567838) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4557) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10925: [FLINK-15690][core][configuration] Enable configuring ExecutionConfig & CheckpointConfig from flink-conf.yaml

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10925:  [FLINK-15690][core][configuration] Enable configuring ExecutionConfig & CheckpointConfig from flink-conf.yaml
URL: https://github.com/apache/flink/pull/10925#issuecomment-577208199
 
 
   <!--
   Meta data
   Hash:fef1d1a01563530a905771e1ef4b23879190be76 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/145567838 TriggerType:PUSH TriggerID:fef1d1a01563530a905771e1ef4b23879190be76
   Hash:fef1d1a01563530a905771e1ef4b23879190be76 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4557 TriggerType:PUSH TriggerID:fef1d1a01563530a905771e1ef4b23879190be76
   -->
   ## CI report:
   
   * fef1d1a01563530a905771e1ef4b23879190be76 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/145567838) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4557) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services