You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/11/16 01:46:28 UTC

[GitHub] [echarts] pissang opened a new pull request #16069: fix(line): fix bezier points calculated wrong when monotone smooth is used.

pissang opened a new pull request #16069:
URL: https://github.com/apache/echarts/pull/16069


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   Fix a wrong factor in the algorithm because of typo.
   
   ### Fixed issues
   
   #15323 
   
   
   ## Details
   
   ### Before: What was the problem?
   
   ![image](https://user-images.githubusercontent.com/841551/141880649-b1e7bede-d504-4a33-9ed5-3039af8a603e.png)
   
   ### After: How is it fixed in this PR?
   
   ![image](https://user-images.githubusercontent.com/841551/141880607-bec1ea2f-3bad-4659-a3b4-b009f919bf10.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] pissang merged pull request #16069: fix(line): fix bezier points calculated wrong when monotone smooth is used.

Posted by GitBox <gi...@apache.org>.
pissang merged pull request #16069:
URL: https://github.com/apache/echarts/pull/16069


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] echarts-bot[bot] commented on pull request #16069: fix(line): fix bezier points calculated wrong when monotone smooth is used.

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #16069:
URL: https://github.com/apache/echarts/pull/16069#issuecomment-969649942


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a committer of this project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] echarts-bot[bot] commented on pull request #16069: fix(line): fix bezier points calculated wrong when monotone smooth is used.

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #16069:
URL: https://github.com/apache/echarts/pull/16069#issuecomment-970102319


   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org