You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/04/02 18:34:41 UTC

[GitHub] mistercrunch commented on a change in pull request #4688: Added DeckGL Test

mistercrunch commented on a change in pull request #4688: Added DeckGL Test
URL: https://github.com/apache/incubator-superset/pull/4688#discussion_r178614358
 
 

 ##########
 File path: tests/viz_tests.py
 ##########
 @@ -634,3 +634,109 @@ def test_rose_vis_get_data(self):
             ],
         }
         self.assertEqual(expected, res)
+
+
+class BaseDeckGLVizTestCase(unittest.TestCase):
+
+    def test_get_metrics(self):
+        form_data = {'size': 'large'}
+        datasource = {'type': 'table'}
 
 Review comment:
   I think `datasource` expects a derivative of `connectors.base.models.BaseDatasource`, I'm surprised this works.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services