You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/06 19:40:00 UTC
[GitHub] [spark] rdblue commented on issue #25040: [SPARK-28238][SQL]
Implement DESCRIBE TABLE for Data Source V2 Tables.
rdblue commented on issue #25040: [SPARK-28238][SQL] Implement DESCRIBE TABLE for Data Source V2 Tables.
URL: https://github.com/apache/spark/pull/25040#issuecomment-508949198
Overall this looks good, but it doesn't move the parser rules to Catalyst. We've been trying to move as much as we can to Catalyst, to keep the parser and the SQL implementation separate instead of keeping them mixed together. That has also required moving the parser tests to Catalyst and moving the SparkSqlParser tests to a suite that tests parsing and conversion to v1 plans.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org