You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2019/12/26 09:37:42 UTC

[GitHub] [servicecomb-pack] WillemJiang commented on a change in pull request #622: [SCB-1685] Change Assert method contains to hasItems

WillemJiang commented on a change in pull request #622: [SCB-1685] Change Assert method contains to hasItems
URL: https://github.com/apache/servicecomb-pack/pull/622#discussion_r361414813
 
 

 ##########
 File path: alpha/alpha-server/src/test/java/org/apache/servicecomb/pack/alpha/server/AlphaIntegrationTest.java
 ##########
 @@ -286,7 +286,7 @@ public void doNotCompensateDuplicateTxOnFailure() {
     blockingStub.onTxEvent(someGrpcEvent(TxAbortedEvent));
     await().atMost(1, SECONDS).until(() -> receivedCommandsCounter.get() > 1);
 
 Review comment:
   The test failure is caused by the receivedCommandCounter is less than 2. 
   I think we should wait for a bit more time for it. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services