[GitHub] [trafficcontrol] ocket8888 commented on issue #4247: TO image: Copy files from a previous build stage instead of trafficops-perl

[GitBox <gi...@apache.org>]

ocket8888 commented on issue #4247: TO image: Copy files from a previous build stage instead of trafficops-perl
URL: https://github.com/apache/trafficcontrol/pull/4247#issuecomment-570026667
 
 
   The reason the builds were coupled was to avoid a mismatch between the TO release versions of the Perl and Go. Arguably the Perl doesn't change much anymore, but it does change e.g. to include deprecation warnings.
   
   It does seem, though, that such a mismatch could only occur with these changes by the direct intent of the person building the images, but another thing to keep in mind is that this is also a problem that solves itself once we can finally kill Perl.
   
   With all that said I'm not opposed to including a change like this, but I do have one question: what do you think about going the route of our caching servers and stemming both services from a common base image that does little more than install the RPM? Then your build layer just becomes an image that is the backbone of both `trafficops` and `trafficops-perl`, which has the same effect but the output images of `docker-compose build` are forcibly always consistent in their TO versions. Though by specifying either `trafficops` or `trafficops-perl` you could still build only the one you care about, thus retaining the build speed improvement.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services