You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/10/25 02:28:37 UTC
Review Request 14917: Fixed FaultToleranceTest.MasterFailover test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14917/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-774
https://issues.apache.org/jira/browse/MESOS-774
Repository: mesos-git
Description
-------
See summary
Diffs
-----
src/tests/fault_tolerance_tests.cpp bef95fb2464dfc507b2c9a2c70a808ad1e1a8764
Diff: https://reviews.apache.org/r/14917/diff/
Testing
-------
make check
sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*FaultToleranceTest.MasterFailover*" --verbose --gtest_repeat=3000 --gtest_break_on_failure
Thanks,
Vinod Kone
Re: Review Request 14917: Fixed FaultToleranceTest.MasterFailover test.
Posted by Vinod Kone <vi...@gmail.com>.
> On Oct. 25, 2013, 12:36 a.m., Ben Mahler wrote:
> > src/tests/fault_tolerance_tests.cpp, line 636
> > <https://reviews.apache.org/r/14917/diff/1/?file=371104#file371104line636>
> >
> > I think you need to set registered back to pending before this line, no? As it stands registered will be ready at this point.
no. that's what i thought too but FutureSatisfy() returns a brand new future.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14917/#review27496
-----------------------------------------------------------
On Oct. 25, 2013, 12:28 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14917/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2013, 12:28 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-774
> https://issues.apache.org/jira/browse/MESOS-774
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> src/tests/fault_tolerance_tests.cpp bef95fb2464dfc507b2c9a2c70a808ad1e1a8764
>
> Diff: https://reviews.apache.org/r/14917/diff/
>
>
> Testing
> -------
>
> make check
>
> sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*FaultToleranceTest.MasterFailover*" --verbose --gtest_repeat=3000 --gtest_break_on_failure
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 14917: Fixed FaultToleranceTest.MasterFailover test.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14917/#review27496
-----------------------------------------------------------
Ship it!
src/tests/fault_tolerance_tests.cpp
<https://reviews.apache.org/r/14917/#comment53422>
I think you need to set registered back to pending before this line, no? As it stands registered will be ready at this point.
- Ben Mahler
On Oct. 25, 2013, 12:28 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14917/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2013, 12:28 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-774
> https://issues.apache.org/jira/browse/MESOS-774
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> src/tests/fault_tolerance_tests.cpp bef95fb2464dfc507b2c9a2c70a808ad1e1a8764
>
> Diff: https://reviews.apache.org/r/14917/diff/
>
>
> Testing
> -------
>
> make check
>
> sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*FaultToleranceTest.MasterFailover*" --verbose --gtest_repeat=3000 --gtest_break_on_failure
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 14917: Fixed FaultToleranceTest.MasterFailover test.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14917/
-----------------------------------------------------------
(Updated Oct. 25, 2013, 12:55 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
benm's. NNFR.
Bugs: MESOS-774
https://issues.apache.org/jira/browse/MESOS-774
Repository: mesos-git
Description
-------
See summary
Diffs (updated)
-----
src/tests/fault_tolerance_tests.cpp bef95fb2464dfc507b2c9a2c70a808ad1e1a8764
Diff: https://reviews.apache.org/r/14917/diff/
Testing
-------
make check
sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*FaultToleranceTest.MasterFailover*" --verbose --gtest_repeat=3000 --gtest_break_on_failure
Thanks,
Vinod Kone