You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by am...@apache.org on 2026/10/17 08:23:48 UTC
(fineract-consumer-facing) branch main updated (4a5a762 -> 23f6a5c)
This is an automated email from the ASF dual-hosted git repository.
Aman-Mittal pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/fineract-consumer-facing.git
from 4a5a762 Merge pull request #205 from Kollishion/fix/frontend-i18n-storage-adapters
add 331b8c1 refactor(transfers): move feign clients behind TransferFineractClient gateway
add ed9b2eb feat(transfers): validate loan overpayment and active status on repayments (#114) - validate destination loan is active and payment does not exceed prepayLoan payoff amount - return HTTP 422 with TransferLoanOverpaymentException or TransferLoanNotActiveException - add unit tests covering overpayment, boundary equal to payoff, and inactive loan rejection - add Cucumber overpayment scenario asserting HTTP 422 and error code - update transfers.adoc documentation and add fro [...]
new 23f6a5c Merge pull request #204 from ayushcodes27/feat/114-loan-payment-limit
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../data/LoanPayoffData.java} | 11 +-
.../TransferFineractClient.java} | 25 ++-
.../service/TransferFineractClientImpl.java | 91 +++++++++
...on.java => TransferLoanNotActiveException.java} | 8 +-
....java => TransferLoanOverpaymentException.java} | 8 +-
.../service/TransfersCommandServiceImpl.java | 41 ++--
.../consumer/cucumber/steps/TransfersSteps.java | 42 ++++
.../service/TransferFineractClientImplTest.java | 174 +++++++++++++++++
.../service/TransfersCommandServiceImplTest.java | 211 ++++++++++++++++-----
...e-generated-fineract-feign-clients-fd283b04.txt | 10 -
.../src/test/resources/features/transfers.feature | 4 +
docs/consumer/features/transfers.adoc | 10 +-
frontend/public/i18n/en.json | 4 +-
frontend/public/i18n/hi.json | 4 +-
14 files changed, 539 insertions(+), 104 deletions(-)
copy consumer/src/main/java/org/apache/fineract/consumer/infrastructure/{exception/ConsumerApiError.java => fineractclient/data/LoanPayoffData.java} (77%)
copy consumer/src/main/java/org/apache/fineract/consumer/infrastructure/fineractclient/{interceptors/FineractTenantHeaderInterceptor.java => service/TransferFineractClient.java} (63%)
create mode 100644 consumer/src/main/java/org/apache/fineract/consumer/infrastructure/fineractclient/service/TransferFineractClientImpl.java
copy consumer/src/main/java/org/apache/fineract/consumer/transfers/command/exception/{TransferStepUpInvalidException.java => TransferLoanNotActiveException.java} (81%)
copy consumer/src/main/java/org/apache/fineract/consumer/transfers/command/exception/{TransferStepUpInvalidException.java => TransferLoanOverpaymentException.java} (80%)
create mode 100644 consumer/src/test/java/org/apache/fineract/consumer/infrastructure/fineractclient/service/TransferFineractClientImplTest.java
(fineract-consumer-facing) 01/01: Merge pull request #204 from ayushcodes27/feat/114-loan-payment-limit
Posted by am...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
Aman-Mittal pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/fineract-consumer-facing.git
commit 23f6a5cc89f8edc1db525fcb2441c9d229a8f532
Merge: 4a5a762 ed9b2eb
Author: Aman Mittal <32...@users.noreply.github.com>
AuthorDate: Sat Oct 17 13:53:41 2026 +0530
Merge pull request #204 from ayushcodes27/feat/114-loan-payment-limit
feat(transfers): validate loan overpayment and active status on repayments (#114)
.../fineractclient/data/LoanPayoffData.java | 38 ++++
.../service/TransferFineractClient.java | 34 ++++
.../service/TransferFineractClientImpl.java | 91 +++++++++
.../exception/TransferLoanNotActiveException.java | 32 ++++
.../TransferLoanOverpaymentException.java | 32 ++++
.../service/TransfersCommandServiceImpl.java | 41 ++--
.../consumer/cucumber/steps/TransfersSteps.java | 42 ++++
.../service/TransferFineractClientImplTest.java | 174 +++++++++++++++++
.../service/TransfersCommandServiceImplTest.java | 211 ++++++++++++++++-----
...e-generated-fineract-feign-clients-fd283b04.txt | 10 -
.../src/test/resources/features/transfers.feature | 4 +
docs/consumer/features/transfers.adoc | 10 +-
frontend/public/i18n/en.json | 4 +-
frontend/public/i18n/hi.json | 4 +-
14 files changed, 650 insertions(+), 77 deletions(-)