You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jsoref (via GitHub)" <gi...@apache.org> on 2023/11/17 15:51:21 UTC

[PR] GH-38764: [JAVA] Clarify warning about `--add-opens=java.base/java.nio=ALL-UNNAMED` [arrow]

jsoref opened a new pull request, #38765:
URL: https://github.com/apache/arrow/pull/38765

   ### Rationale for this change
   
   When someone encounters this message, it's precisely because they did *not* include `--add-opens=java.base/java.nio=ALL-UNNAMED`, but in order for arrow to work, they will need to add it.
   
   #38764
   
   ### What changes are included in this PR?
   
   Changes `with` to `without`
   
   ### Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   ### Are there any user-facing changes?
   
   The error message when arrow is run on a modern JVM will change from `with` to `without`:
   > java.lang.RuntimeException: Failed to initialize MemoryUtil. Was Java started without `--add-opens=java.base/java.nio=ALL-UNNAMED`? (See https://arrow.apache.org/docs/java/install.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] GH-38764: [Java] Clarify warning about `--add-opens=java.base/java.nio=ALL-UNNAMED` [arrow]

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #38765:
URL: https://github.com/apache/arrow/pull/38765#issuecomment-1819589488

   After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit c21d197306e48c2868d7ad32cc9e41e844a4baf8.
   
   There were no benchmark performance regressions. 🎉
   
   The [full Conbench report](https://github.com/apache/arrow/runs/18862034592) has more details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] GH-38764: [JAVA] Clarify warning about `--add-opens=java.base/java.nio=ALL-UNNAMED` [arrow]

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #38765:
URL: https://github.com/apache/arrow/pull/38765#discussion_r1397718323


##########
java/memory/memory-core/src/main/java/org/apache/arrow/memory/util/MemoryUtil.java:
##########
@@ -141,7 +141,7 @@ public Object run() {
       // This exception will get swallowed, but it's necessary for the static analysis that ensures
       // the static fields above get initialized
       final RuntimeException failure = new RuntimeException(
-          "Failed to initialize MemoryUtil. Was Java started with " +
+          "Failed to initialize MemoryUtil. Was Java started without " +

Review Comment:
   Maybe just make it imperative to be absolutely clear? "You must start Java with ..."



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] GH-38764: [Java] Clarify warning about `--add-opens=java.base/java.nio=ALL-UNNAMED` [arrow]

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #38765:
URL: https://github.com/apache/arrow/pull/38765


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] GH-38764: [JAVA] Clarify warning about `--add-opens=java.base/java.nio=ALL-UNNAMED` [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38765:
URL: https://github.com/apache/arrow/pull/38765#issuecomment-1816671963

   :warning: GitHub issue #38764 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] GH-38764: [JAVA] Clarify warning about `--add-opens=java.base/java.nio=ALL-UNNAMED` [arrow]

Posted by "danepitkin (via GitHub)" <gi...@apache.org>.
danepitkin commented on code in PR #38765:
URL: https://github.com/apache/arrow/pull/38765#discussion_r1397899956


##########
java/memory/memory-core/src/main/java/org/apache/arrow/memory/util/MemoryUtil.java:
##########
@@ -141,7 +141,7 @@ public Object run() {
       // This exception will get swallowed, but it's necessary for the static analysis that ensures
       // the static fields above get initialized
       final RuntimeException failure = new RuntimeException(
-          "Failed to initialize MemoryUtil. Was Java started with " +
+          "Failed to initialize MemoryUtil. You must start Java with " +
               "`--add-opens=java.base/java.nio=ALL-UNNAMED`? " +

Review Comment:
   ```suggestion
             "Failed to initialize MemoryUtil. You must start Java with " +
                 "`--add-opens=java.base/java.nio=ALL-UNNAMED` " +
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org