You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by GitBox <gi...@apache.org> on 2020/10/19 15:18:03 UTC

[GitHub] [lucenenet] theolivenbaum opened a new pull request #376: Add extension method to avoid boxing IndexOptions, closes #375

theolivenbaum opened a new pull request #376:
URL: https://github.com/apache/lucenenet/pull/376


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [lucenenet] NightOwl888 closed pull request #376: Add extension method to avoid boxing IndexOptions, closes #375

Posted by GitBox <gi...@apache.org>.
NightOwl888 closed pull request #376:
URL: https://github.com/apache/lucenenet/pull/376


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [lucenenet] theolivenbaum commented on pull request #376: Add extension method to avoid boxing IndexOptions, closes #375

Posted by GitBox <gi...@apache.org>.
theolivenbaum commented on pull request #376:
URL: https://github.com/apache/lucenenet/pull/376#issuecomment-712395768


   By the way, just went for the odd name because adding an extension method with the name of the existing enum.CompareTo didn't change anything, the boxing version of the method was still being called...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [lucenenet] theolivenbaum commented on pull request #376: Add extension method to avoid boxing IndexOptions, closes #375

Posted by GitBox <gi...@apache.org>.
theolivenbaum commented on pull request #376:
URL: https://github.com/apache/lucenenet/pull/376#issuecomment-712395372


   That makes the find & replace a bit more challenging :)
   But will do the changes and get back to you tomorrow with an updated version!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [lucenenet] theolivenbaum commented on pull request #376: Add extension method to avoid boxing IndexOptions, closes #375

Posted by GitBox <gi...@apache.org>.
theolivenbaum commented on pull request #376:
URL: https://github.com/apache/lucenenet/pull/376#issuecomment-712308763


   Fix for #375 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [lucenenet] NightOwl888 commented on pull request #376: Add extension method to avoid boxing IndexOptions, closes #375

Posted by GitBox <gi...@apache.org>.
NightOwl888 commented on pull request #376:
URL: https://github.com/apache/lucenenet/pull/376#issuecomment-721417777


   Thanks again for identifying this, but I beat you to it in #384 :).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [lucenenet] NightOwl888 commented on pull request #376: Add extension method to avoid boxing IndexOptions, closes #375

Posted by GitBox <gi...@apache.org>.
NightOwl888 commented on pull request #376:
URL: https://github.com/apache/lucenenet/pull/376#issuecomment-721445172


   BTW - this is the 3rd boxing issue that has been found recently. Be on the lookout for more. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org