You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Giridharan Kesavan (JIRA)" <ji...@apache.org> on 2009/02/12 11:43:59 UTC
[jira] Created: (HADOOP-5232) preparing
HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson
slaves.
preparing HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson slaves.
----------------------------------------------------------------------------------------
Key: HADOOP-5232
URL: https://issues.apache.org/jira/browse/HADOOP-5232
Project: Hadoop Core
Issue Type: New Feature
Components: build
Reporter: Giridharan Kesavan
To modify hadoopPatchQueueAdmin.sh and test-patch.sh script to run patch builds on hudson slaves.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-5232) preparing
HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson
slaves.
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Giridharan Kesavan reassigned HADOOP-5232:
------------------------------------------
Assignee: Giridharan Kesavan
> preparing HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson slaves.
> ----------------------------------------------------------------------------------------
>
> Key: HADOOP-5232
> URL: https://issues.apache.org/jira/browse/HADOOP-5232
> Project: Hadoop Core
> Issue Type: New Feature
> Components: build
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
>
> To modify hadoopPatchQueueAdmin.sh and test-patch.sh script to run patch builds on hudson slaves.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5232) preparing
HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson
slaves.
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nigel Daley updated HADOOP-5232:
--------------------------------
Hadoop Flags: [Reviewed]
+1
> preparing HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson slaves.
> ----------------------------------------------------------------------------------------
>
> Key: HADOOP-5232
> URL: https://issues.apache.org/jira/browse/HADOOP-5232
> Project: Hadoop Core
> Issue Type: New Feature
> Components: build
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Attachments: hudsonPatchQueueAdmin.sh.patch, nightly.patch, nightly.patch, test-patch.sh.patch, test.patch
>
>
> To modify hadoopPatchQueueAdmin.sh and test-patch.sh script to run patch builds on hudson slaves.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5232) preparing
HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson
slaves.
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Giridharan Kesavan updated HADOOP-5232:
---------------------------------------
Attachment: nightly.patch
fixed a typo in the nightly patch.
> preparing HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson slaves.
> ----------------------------------------------------------------------------------------
>
> Key: HADOOP-5232
> URL: https://issues.apache.org/jira/browse/HADOOP-5232
> Project: Hadoop Core
> Issue Type: New Feature
> Components: build
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Attachments: hudsonPatchQueueAdmin.sh.patch, nightly.patch, nightly.patch, nightly.patch, test-patch.sh.patch, test.patch
>
>
> To modify hadoopPatchQueueAdmin.sh and test-patch.sh script to run patch builds on hudson slaves.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5232) preparing
HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson
slaves.
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676886#action_12676886 ]
Giridharan Kesavan commented on HADOOP-5232:
--------------------------------------------
with the latest test.patch defect # is getting passed as an arg to the test-patch.sh script.
> preparing HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson slaves.
> ----------------------------------------------------------------------------------------
>
> Key: HADOOP-5232
> URL: https://issues.apache.org/jira/browse/HADOOP-5232
> Project: Hadoop Core
> Issue Type: New Feature
> Components: build
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Attachments: hudsonPatchQueueAdmin.sh.patch, nightly.patch, nightly.patch, nightly.patch, test-patch.sh.patch, test.patch, test.patch
>
>
> To modify hadoopPatchQueueAdmin.sh and test-patch.sh script to run patch builds on hudson slaves.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5232) preparing
HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson
slaves.
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Giridharan Kesavan updated HADOOP-5232:
---------------------------------------
Attachment: test.patch
> preparing HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson slaves.
> ----------------------------------------------------------------------------------------
>
> Key: HADOOP-5232
> URL: https://issues.apache.org/jira/browse/HADOOP-5232
> Project: Hadoop Core
> Issue Type: New Feature
> Components: build
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Attachments: hudsonPatchQueueAdmin.sh.patch, nightly.patch, nightly.patch, nightly.patch, test-patch.sh.patch, test.patch, test.patch
>
>
> To modify hadoopPatchQueueAdmin.sh and test-patch.sh script to run patch builds on hudson slaves.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5232) preparing
HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson
slaves.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677025#action_12677025 ]
Hudson commented on HADOOP-5232:
--------------------------------
Integrated in Hadoop-trunk #766 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/766/])
. Enable patch testing to occur on more than one host. Contributed by Giri Kesavan.
. Enable patch testing to occur on more than one host. Contributed by Giri Kesavan.
> preparing HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson slaves.
> ----------------------------------------------------------------------------------------
>
> Key: HADOOP-5232
> URL: https://issues.apache.org/jira/browse/HADOOP-5232
> Project: Hadoop Core
> Issue Type: New Feature
> Components: build
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Fix For: 0.21.0
>
> Attachments: hudsonPatchQueueAdmin.sh.patch, nightly.patch, nightly.patch, nightly.patch, test-patch.sh.patch, test.patch, test.patch
>
>
> To modify hadoopPatchQueueAdmin.sh and test-patch.sh script to run patch builds on hudson slaves.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5232) preparing
HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson
slaves.
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674503#action_12674503 ]
Nigel Daley commented on HADOOP-5232:
-------------------------------------
Thanks Giri.
Comments on hudsonPatchQueueAdmin.sh.patch:
# why is $3 used instead of assigning to a variable name?
# set -x shouldn't be set in this script as it will leak the build token secret (which I think is $3) to the console
# where is BUILD_SERVERS defined? CALLEDBY?
# why use a directory to store defectNum ($CURRENT_DIR/defectNum)? -- instead just keep defect numbers in a single file
# please preserve 2 space indents
# removed un-used lines (like #TRIGGER_BUILD_URL=$3)
Comments on test-patch.sh.patch:
# where's the 18th parameter?
# give more info on *why* in this echo: "Calling the Patch Queue Admin"
Can you provide examples of how these scripts are now called? (don't leak the secret build token).
> preparing HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson slaves.
> ----------------------------------------------------------------------------------------
>
> Key: HADOOP-5232
> URL: https://issues.apache.org/jira/browse/HADOOP-5232
> Project: Hadoop Core
> Issue Type: New Feature
> Components: build
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Attachments: hudsonPatchQueueAdmin.sh.patch, test-patch.sh.patch
>
>
> To modify hadoopPatchQueueAdmin.sh and test-patch.sh script to run patch builds on hudson slaves.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5232) preparing
HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson
slaves.
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673804#action_12673804 ]
Giridharan Kesavan commented on HADOOP-5232:
--------------------------------------------
Im thinking of having another parametrized hudson job just to do the cleanup of the current folder;
This will be done by the test-patch.sh script which would call the hudson job as part of the cleanupAndExit function.
> preparing HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson slaves.
> ----------------------------------------------------------------------------------------
>
> Key: HADOOP-5232
> URL: https://issues.apache.org/jira/browse/HADOOP-5232
> Project: Hadoop Core
> Issue Type: New Feature
> Components: build
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
>
> To modify hadoopPatchQueueAdmin.sh and test-patch.sh script to run patch builds on hudson slaves.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HADOOP-5232) preparing
HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson
slaves.
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nigel Daley resolved HADOOP-5232.
---------------------------------
Resolution: Fixed
Fix Version/s: 0.21.0
I just committed this. Thanks Giri.
> preparing HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson slaves.
> ----------------------------------------------------------------------------------------
>
> Key: HADOOP-5232
> URL: https://issues.apache.org/jira/browse/HADOOP-5232
> Project: Hadoop Core
> Issue Type: New Feature
> Components: build
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Fix For: 0.21.0
>
> Attachments: hudsonPatchQueueAdmin.sh.patch, nightly.patch, nightly.patch, nightly.patch, test-patch.sh.patch, test.patch, test.patch
>
>
> To modify hadoopPatchQueueAdmin.sh and test-patch.sh script to run patch builds on hudson slaves.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5232) preparing
HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson
slaves.
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676190#action_12676190 ]
Nigel Daley commented on HADOOP-5232:
-------------------------------------
Looks good. More comments:
hudsonPatchQueueAdmin.sh
# comment "The complete URL to trigger a build" is now wrong
# if CALLEDBY... needs some comments
# $CUR should be $CURL
# ...DEFECTNUM=`cat $CURRENT_PATCH` should be $...DEFECTNUM=$defect
> preparing HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson slaves.
> ----------------------------------------------------------------------------------------
>
> Key: HADOOP-5232
> URL: https://issues.apache.org/jira/browse/HADOOP-5232
> Project: Hadoop Core
> Issue Type: New Feature
> Components: build
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Attachments: hudsonPatchQueueAdmin.sh.patch, nightly.patch, test-patch.sh.patch, test.patch
>
>
> To modify hadoopPatchQueueAdmin.sh and test-patch.sh script to run patch builds on hudson slaves.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5232) preparing
HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson
slaves.
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673805#action_12673805 ]
Nigel Daley commented on HADOOP-5232:
-------------------------------------
Interesting idea. I suppose you could call Hadoop-Patch-Admin with a parameter. Then you'd get the cleanup done and the next patch kicked off right away.
> preparing HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson slaves.
> ----------------------------------------------------------------------------------------
>
> Key: HADOOP-5232
> URL: https://issues.apache.org/jira/browse/HADOOP-5232
> Project: Hadoop Core
> Issue Type: New Feature
> Components: build
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
>
> To modify hadoopPatchQueueAdmin.sh and test-patch.sh script to run patch builds on hudson slaves.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5232) preparing
HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson
slaves.
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Giridharan Kesavan updated HADOOP-5232:
---------------------------------------
Attachment: test.patch
nightly.patch
I 've addressed all your comments from Nigel and submitting an improved version of the patch here...
We have two patch here. one is called the nightly.patch which we should apply in the nightly folder
and the second one called test.patch which we should apply on the hadoop base folder.
All the comments mentioned by Nigel are addressed by these two patches. We no more have a folder for queues. we have a simple txt file which acts as a patch queue.
Please Review.
Here are the example cmd for patch-admin job and the patch build job.
###################################################
PATCH_ADMIN_BUILD
CALLER IS THE HUDSON PARAMATERISED VARIABLE and HAS ITS DEFAULT VALUE SET TO USER
CMD:
export BUILD_SERVERS="<SERVER2 HOSTNAME> <SERVER2 HOSTNAME>"
CALLEDBY=${CALLER}
export CALLEDBY
cd $workspace\nightly
sh hudsonPatchQueueAdmin.sh HADOOP <patch_queue_dir> </buildWithParameters?token=<token> <PATH_TO_CURL>
###########################################
PATCH BUILD:
DEFECTNUM IS THE HUDSON PARAMATERISED VARIABLE and HAS ITS DEFAULT VALUE SET TO ""
cmd:
export defect=${DEFECTNUM}
export PATCH_ADMIN_URL=http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/buildWithParameters?token=<token>
other options remaining the same we would be modifying the value for trigger.url
-Dtrigger.url=http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-Admin//buildWithParameters?token=<token>
and we would add one more variable for curl.
-Dcurl.cmd=<path to curl>
#############################################################
> preparing HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson slaves.
> ----------------------------------------------------------------------------------------
>
> Key: HADOOP-5232
> URL: https://issues.apache.org/jira/browse/HADOOP-5232
> Project: Hadoop Core
> Issue Type: New Feature
> Components: build
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Attachments: hudsonPatchQueueAdmin.sh.patch, nightly.patch, test-patch.sh.patch, test.patch
>
>
> To modify hadoopPatchQueueAdmin.sh and test-patch.sh script to run patch builds on hudson slaves.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5232) preparing
HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson
slaves.
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Giridharan Kesavan updated HADOOP-5232:
---------------------------------------
Attachment: nightly.patch
updated the patch as per comments...
Added more functionality to the email processing script -processHadoopPatchEmail.sh and hudsonPatchQueueAdmin.sh
* email processing scirpt checks for duplicate defect in the patch queue before adding defects to the queue
* hudsonPatchQueueAdmin.sh doesnt require any env variables. It uses getopts to parse the cmd line arguments.
*example*
{noformat}
sh hudsonPatchQueueAdmin.sh -p<PROJECT> -s'SERVER1 SERVER2' -c<CALLING SERVER HOSTNAME> -t<PATH TO CURL> -u</buildWithParameters?token=<token>> -q<path to the patch queue>
To enable execute the script in debug mode use -v along with other args.
To display the script usage use the -h option.
sh hudsonPatchQueueAdmin.sh -h {noformat}
> preparing HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson slaves.
> ----------------------------------------------------------------------------------------
>
> Key: HADOOP-5232
> URL: https://issues.apache.org/jira/browse/HADOOP-5232
> Project: Hadoop Core
> Issue Type: New Feature
> Components: build
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Attachments: hudsonPatchQueueAdmin.sh.patch, nightly.patch, nightly.patch, test-patch.sh.patch, test.patch
>
>
> To modify hadoopPatchQueueAdmin.sh and test-patch.sh script to run patch builds on hudson slaves.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5232) preparing
HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson
slaves.
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674293#action_12674293 ]
Giridharan Kesavan commented on HADOOP-5232:
--------------------------------------------
I agree with your idea; I would make the changes appropriately and upload the patch..tnx!
> preparing HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson slaves.
> ----------------------------------------------------------------------------------------
>
> Key: HADOOP-5232
> URL: https://issues.apache.org/jira/browse/HADOOP-5232
> Project: Hadoop Core
> Issue Type: New Feature
> Components: build
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
>
> To modify hadoopPatchQueueAdmin.sh and test-patch.sh script to run patch builds on hudson slaves.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5232) preparing
HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson
slaves.
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673693#action_12673693 ]
Giridharan Kesavan commented on HADOOP-5232:
--------------------------------------------
Here is the proposal for running parallel patch builds using hudson slaves.
Plan:
hudson.zones will continue to parse all the jira email traffic.
hudson.zones will continue to run the patchAdmin job.
hudson patch jobs will be created per slave basis. [rest assured that the patch runs only on that slave]
ie. Whenever we plan to add a new hudson slave machine we need to create/add new job hadoop-patch job inhudson
explicitly for that slave.
slave/master communication happens through parametrized builds and posting values through url.
And it seems this parametrized builds are supported since hudson version - 1.278
We have to upgrade our hudson.zones-1.268 to run hudson 1.278 to utilize this feature.
Apart from this we have to modify the way the patch admin calls the patch builds to use parametrized builds.
Also the test-patch.sh script in the src/test/bin had to be modified to accomodate hudson slave patch builds.
Finally the patchqueue html page will show up the currentpatch build's on different slaves at any point in time.
> preparing HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson slaves.
> ----------------------------------------------------------------------------------------
>
> Key: HADOOP-5232
> URL: https://issues.apache.org/jira/browse/HADOOP-5232
> Project: Hadoop Core
> Issue Type: New Feature
> Components: build
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
>
> To modify hadoopPatchQueueAdmin.sh and test-patch.sh script to run patch builds on hudson slaves.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5232) preparing
HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson
slaves.
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673802#action_12673802 ]
Nigel Daley commented on HADOOP-5232:
-------------------------------------
Looks good. How do you plan to remove the 'current' directory from the patch queue once a build completes? Do you have a patch?
> preparing HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson slaves.
> ----------------------------------------------------------------------------------------
>
> Key: HADOOP-5232
> URL: https://issues.apache.org/jira/browse/HADOOP-5232
> Project: Hadoop Core
> Issue Type: New Feature
> Components: build
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
>
> To modify hadoopPatchQueueAdmin.sh and test-patch.sh script to run patch builds on hudson slaves.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5232) preparing
HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson
slaves.
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Giridharan Kesavan updated HADOOP-5232:
---------------------------------------
Attachment: test-patch.sh.patch
hudsonPatchQueueAdmin.sh.patch
patch for test-patch.sh and patch for hudsonPatchQueueAdmin.sh attached to exuecute patch build on hudson slaves..
> preparing HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson slaves.
> ----------------------------------------------------------------------------------------
>
> Key: HADOOP-5232
> URL: https://issues.apache.org/jira/browse/HADOOP-5232
> Project: Hadoop Core
> Issue Type: New Feature
> Components: build
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Attachments: hudsonPatchQueueAdmin.sh.patch, test-patch.sh.patch
>
>
> To modify hadoopPatchQueueAdmin.sh and test-patch.sh script to run patch builds on hudson slaves.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (HADOOP-5232) preparing
HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson
slaves.
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676023#action_12676023 ]
gkesavan edited comment on HADOOP-5232 at 2/23/09 11:24 AM:
----------------------------------------------------------------------
I 've addressed all your comments from Nigel and submitting an improved version of the patch here...
We have two patch here. one is called the nightly.patch which we should apply in the nightly folder
and the second one called test.patch which we should apply on the hadoop base folder.
All the comments mentioned by Nigel are addressed by these two patches. We no more have a folder for queues. we have a simple txt file which acts as a patch queue.
Please Review.
Here are the example cmd for patch-admin job and the patch build job.
###################################################
PATCH_ADMIN_BUILD
CALLER IS THE HUDSON PARAMATERISED VARIABLE and HAS ITS DEFAULT VALUE SET TO USER
CMD:
export BUILD_SERVERS="<SERVER2 HOSTNAME> <SERVER2 HOSTNAME>"
CALLEDBY=${CALLER}
export CALLEDBY
cd $workspace\nightly
sh hudsonPatchQueueAdmin.sh HADOOP <patch_queue_dir> </buildWithParameters?token=<token> <PATH_TO_CURL>
###########################################
PATCH BUILD:
DEFECTNUM IS THE HUDSON PARAMATERISED VARIABLE and HAS ITS DEFAULT VALUE SET TO ""
cmd:
export defect=${DEFECTNUM}
export PATCH_ADMIN_URL=http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-Admin/buildWithParameters?token=<token>
other options remaining the same we would be modifying the value for trigger.url
-Dtrigger.url=http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/buildWithParameters?token=<token>
and we would add one more variable for curl.
-Dcurl.cmd=<path to curl>
#############################################################
was (Author: gkesavan):
I 've addressed all your comments from Nigel and submitting an improved version of the patch here...
We have two patch here. one is called the nightly.patch which we should apply in the nightly folder
and the second one called test.patch which we should apply on the hadoop base folder.
All the comments mentioned by Nigel are addressed by these two patches. We no more have a folder for queues. we have a simple txt file which acts as a patch queue.
Please Review.
Here are the example cmd for patch-admin job and the patch build job.
###################################################
PATCH_ADMIN_BUILD
CALLER IS THE HUDSON PARAMATERISED VARIABLE and HAS ITS DEFAULT VALUE SET TO USER
CMD:
export BUILD_SERVERS="<SERVER2 HOSTNAME> <SERVER2 HOSTNAME>"
CALLEDBY=${CALLER}
export CALLEDBY
cd $workspace\nightly
sh hudsonPatchQueueAdmin.sh HADOOP <patch_queue_dir> </buildWithParameters?token=<token> <PATH_TO_CURL>
###########################################
PATCH BUILD:
DEFECTNUM IS THE HUDSON PARAMATERISED VARIABLE and HAS ITS DEFAULT VALUE SET TO ""
cmd:
export defect=${DEFECTNUM}
export PATCH_ADMIN_URL=http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/buildWithParameters?token=<token>
other options remaining the same we would be modifying the value for trigger.url
-Dtrigger.url=http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-Admin//buildWithParameters?token=<token>
and we would add one more variable for curl.
-Dcurl.cmd=<path to curl>
#############################################################
> preparing HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson slaves.
> ----------------------------------------------------------------------------------------
>
> Key: HADOOP-5232
> URL: https://issues.apache.org/jira/browse/HADOOP-5232
> Project: Hadoop Core
> Issue Type: New Feature
> Components: build
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Attachments: hudsonPatchQueueAdmin.sh.patch, nightly.patch, test-patch.sh.patch, test.patch
>
>
> To modify hadoopPatchQueueAdmin.sh and test-patch.sh script to run patch builds on hudson slaves.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.