You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/26 12:21:51 UTC
[GitHub] [spark] panbingkun opened a new pull request, #38808: [SPARK-41272][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_2019
panbingkun opened a new pull request, #38808:
URL: https://github.com/apache/spark/pull/38808
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass GA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #38808: [SPARK-41272][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_2019
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #38808:
URL: https://github.com/apache/spark/pull/38808#issuecomment-1328140880
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #38808: [SPARK-41272][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_2019
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #38808:
URL: https://github.com/apache/spark/pull/38808#issuecomment-1328741221
+1, LGTM. Merging to master.
Thank you, @panbingkun.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #38808: [SPARK-41272][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_2019
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #38808: [SPARK-41272][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_2019
URL: https://github.com/apache/spark/pull/38808
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #38808: [SPARK-41272][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_2019
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #38808:
URL: https://github.com/apache/spark/pull/38808#discussion_r1032999855
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -735,6 +735,11 @@
"The <joinType> JOIN with LATERAL correlation is not allowed because an OUTER subquery cannot correlate to its join partner. Remove the LATERAL correlation or use an INNER JOIN, or LEFT OUTER JOIN instead."
]
},
+ "INVALID_MAP_KEY" : {
Review Comment:
It is too generic for the error. How about `NULL_MAP_KEY`. cc @srielau
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -735,6 +735,11 @@
"The <joinType> JOIN with LATERAL correlation is not allowed because an OUTER subquery cannot correlate to its join partner. Remove the LATERAL correlation or use an INNER JOIN, or LEFT OUTER JOIN instead."
]
},
+ "INVALID_MAP_KEY" : {
+ "message" : [
+ "Cannot use null as map key!"
Review Comment:
```suggestion
"Cannot use null as map key."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org