You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by clebertsuconic <gi...@git.apache.org> on 2018/03/06 23:50:07 UTC

[GitHub] activemq-artemis pull request #1822: ARTEMIS-1653 Allow database tables to b...

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1822#discussion_r172699944
  
    --- Diff: artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java ---
    @@ -109,7 +109,7 @@ public void stop() throws SQLException {
        protected abstract void createSchema() throws SQLException;
     
        protected final void createTable(String... schemaSqls) throws SQLException {
    -      createTableIfNotExists(connection, sqlProvider.getTableName(), schemaSqls);
    +      createTableIfNotExists(sqlProvider.getTableName(), schemaSqls);
    --- End diff --
    
    easier to ask than reading the code :)
    
    
    Why removing this parameter here?
    
    
    (sorry if I'm lazy.. I have a bunch of other PRs to check.. so it was easier to ask).


---