[GitHub] [phoenix-omid] Aarchy commented on a diff in pull request #109: OMID-223 Refactor Omid to use HBase 2 APIs internally.

[GitBox <gi...@apache.org>]

Aarchy commented on code in PR #109:
URL: https://github.com/apache/phoenix-omid/pull/109#discussion_r945500706


##########
hbase-coprocessor/src/main/java/org/apache/omid/transaction/CellSkipFilterBase.java:
##########
@@ -53,21 +53,21 @@ public CellSkipFilterBase(Filter filter) {
      */
     private boolean skipCellVersion(Cell cell) {
         return skipColumn != null
-        && CellUtil.matchingRow(cell, skipColumn.getRowArray(), skipColumn.getRowOffset(),
+        && PrivateCellUtil.matchingRows(cell, skipColumn.getRowArray(), skipColumn.getRowOffset(),

Review Comment:
   I agree that InterfaceAudience.Private methods should be avoided. Nonetheless, I used it here because the class already has a KeyValue field which is also InterfaceAudience.Private. 
   An alternative solution could be to use Cell instead of KeyValue, and maybe CellUtil.matchingRows(Cell, Cell) instead of this call. How do you think? How should line 73 be changed in this case?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org