Re: [PR] feat(mssql): use the dynamic connection form via BasicParametersMixin [superset]

["codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>]

codeant-ai-for-open-source[bot] commented on code in PR #44281:
URL: https://github.com/apache/superset/pull/44281#discussion_r4171076530


##########
superset/db_engine_specs/mssql.py:
##########
@@ -58,6 +64,18 @@ class MssqlEngineSpec(BaseEngineSpec):
     identifier_quote_start: str = "["
     identifier_quote_end: str = "]"
 
+    # Enables the dynamic connection form: the recommended pymssql driver uses a
+    # standard host/port/username/password/database URI, so ``BasicParametersMixin``
+    # can build it as ``mssql+pymssql://user:pass@host:port/db``.
+    default_driver = "pymssql"
+    parameters_schema = BasicParametersSchema()
+    sqlalchemy_uri_placeholder = (
+        "mssql+pymssql://user:password@host:port/dbname[?key=value&key=value...]"
+    )
+    # pymssql negotiates TLS at the TDS protocol level rather than through a URI
+    # query parameter, so there is no encryption flag to inject into the URL.
+    encryption_parameters: dict[str, str] = {}

Review Comment:
   ✅ **CodeAnt verified this suggestion was addressed in subsequent commits and marked this thread resolved** as of `3bc7cdc`.
   
   The parameters schema now excludes `encryption`, preventing the form from exposing an unsupported option that would fail URI construction.
   
   <sub>If that's not right, unresolve this thread and CodeAnt will leave it open.</sub>
   
   <!-- codeant-auto-resolve-reply -->



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org