[GitHub] [ozone] vivekratnavel commented on a change in pull request #2593: HDDS-5692. Combine some tests in TestOzoneManagerHAWithData to reuse mini-Clusters

[GitBox <gi...@apache.org>]

vivekratnavel commented on a change in pull request #2593:
URL: https://github.com/apache/ozone/pull/2593#discussion_r697730521



##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerHAWithData.java
##########
@@ -250,8 +249,7 @@ public void testFileOperationsWithNonRecursive() throws Exception {
 
   }
 
-  @Test
-  public void testMultipartUploadWithOneOmNodeDown() throws Exception {
+  private void testMultipartUploadWithOneOmNodeDown() throws Exception {
 
     OzoneBucket ozoneBucket = setupBucket();
 

Review comment:
       Findbug reports a warning in Line 280 for the comparison operator used (!=) 
   
   Can we fix it to get a clean run?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org