You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/11 11:56:49 UTC
[GitHub] [apisix] iamayushdas opened a new pull request #4025: fix: made dark mode compatible APISIX architecture image
iamayushdas opened a new pull request #4025:
URL: https://github.com/apache/apisix/pull/4025
### What this PR does / why we need it:
To make the apisix architecture image compatible to dark mode
[#301](https://github.com/apache/apisix-website/issues/301) from apisix-website
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [x] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #4025: docs: made dark mode compatible APISIX architecture image
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #4025:
URL: https://github.com/apache/apisix/pull/4025#discussion_r611285463
##########
File path: docs/en/latest/config.json
##########
@@ -1,6 +1,11 @@
{
"version": 2.4,
"sidebar": [
+ {
+ "type": "link",
+ "label": "Apache APISIX",
+ "href" : "https://apisix.apache.org/docs/apisix/getting-started"
Review comment:
I see, @iamayushdas it seems that you have historical commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] iamayushdas commented on pull request #4025: fix: made dark mode compatible APISIX architecture image
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #4025:
URL: https://github.com/apache/apisix/pull/4025#issuecomment-817295898
@juzhiyuan @Yiyiyimu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] iamayushdas closed pull request #4025: docs: made dark mode compatible APISIX architecture image
Posted by GitBox <gi...@apache.org>.
iamayushdas closed pull request #4025:
URL: https://github.com/apache/apisix/pull/4025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4025: fix: made dark mode compatible APISIX architecture image
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4025:
URL: https://github.com/apache/apisix/pull/4025#discussion_r611275190
##########
File path: docs/en/latest/config.json
##########
@@ -1,6 +1,11 @@
{
"version": 2.4,
"sidebar": [
+ {
+ "type": "link",
+ "label": "Apache APISIX",
+ "href" : "https://apisix.apache.org/docs/apisix/getting-started"
Review comment:
Why add this link?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] iamayushdas commented on a change in pull request #4025: docs: made dark mode compatible APISIX architecture image
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #4025:
URL: https://github.com/apache/apisix/pull/4025#discussion_r611287463
##########
File path: docs/en/latest/config.json
##########
@@ -1,6 +1,11 @@
{
"version": 2.4,
"sidebar": [
+ {
+ "type": "link",
+ "label": "Apache APISIX",
+ "href" : "https://apisix.apache.org/docs/apisix/getting-started"
Review comment:
Yes 😩 going to fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org