You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by bu...@apache.org on 2006/08/04 07:38:05 UTC
DO NOT REPLY [Bug 40184] - Move stuff from Property to PropertyHelper patch
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40184>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=40184
------- Additional Comments From efanomars@yahoo.com 2006-08-04 05:38 -------
Created an attachment (id=18677)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=18677&action=view)
Modified Property, PropertyHelper
** Sources **
PropertyHelper.java:
- added public setNewInheritedProperty(ns, n, v)
like setNewProperty, adds a user property only if
there isn't one already defined
- added addNewProperties(ns, props, prefix)
resolves, expands, prefixes and adds a set of properties
- added addNewInheritedProperties(ns, props, prefix)
resolves, expands, prefixes and adds a set of user properties
Property.java:
- removed resolveAllProperties(props), now in PropertyHelper
- modified addProperties and addProperty to call the
corresponding PropertyHelper methods
** Tests **
No additional testcases added.
** Note **
Modified and patched against latest 1.70alpha.
I did this patch a bit quickly. Probably everything
(interface, comments, implementation) can be improved.
Maybe the public methods added to the PropertyHelper
should also be added to the Project (and called from
the Property task)?
(I also noticed that replaceProperties is not synchronized,
I'm not sure but maybe properties could be set while
replacing, leading to inconsistent results (not in the patch).)
Stefano Marsili
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org