You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/29 03:10:25 UTC
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request
#4524: Fix typo for TableTokenGenerator.isToGenerateTableTokenForRightValue
terrymanu opened a new pull request #4524: Fix typo for TableTokenGenerator.isToGenerateTableTokenForRightValue
URL: https://github.com/apache/incubator-shardingsphere/pull/4524
The bug is use left value to judge right value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4524: Fix typo for TableTokenGenerator.isToGenerateTableTokenForRightValue
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4524: Fix typo for TableTokenGenerator.isToGenerateTableTokenForRightValue
URL: https://github.com/apache/incubator-shardingsphere/pull/4524#issuecomment-592846915
## Pull Request Test Coverage Report for [Build 9868](https://coveralls.io/builds/29042584)
* **33** of **38** **(86.84%)** changed or added relevant lines in **2** files are covered.
* **3** unchanged lines in **1** file lost coverage.
* Overall coverage decreased (**-0.004%**) to **59.132%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/sharding/rewrite/token/generator/impl/TableTokenGenerator.java](https://coveralls.io/builds/29042584/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Frewrite%2Ftoken%2Fgenerator%2Fimpl%2FTableTokenGenerator.java#L67) | 20 | 25 | 80.0%
<!-- | **Total:** | **33** | **38** | **86.84%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/29042584/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
<!-- | **Total:** | **3** | | -->
| Totals | [](https://coveralls.io/builds/29042584) |
| :-- | --: |
| Change from base [Build 951](https://coveralls.io/builds/29023442): | -0.004% |
| Covered Lines: | 10606 |
| Relevant Lines: | 17936 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4524:
Fix typo for TableTokenGenerator.isToGenerateTableTokenForRightValue
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #4524: Fix typo for TableTokenGenerator.isToGenerateTableTokenForRightValue
URL: https://github.com/apache/incubator-shardingsphere/pull/4524
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4524: Fix
typo for TableTokenGenerator.isToGenerateTableTokenForRightValue
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4524: Fix typo for TableTokenGenerator.isToGenerateTableTokenForRightValue
URL: https://github.com/apache/incubator-shardingsphere/pull/4524#issuecomment-592846915
## Pull Request Test Coverage Report for [Build 16](https://coveralls.io/builds/29042578)
* **33** of **38** **(86.84%)** changed or added relevant lines in **2** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage increased (+**0.007%**) to **59.144%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/sharding/rewrite/token/generator/impl/TableTokenGenerator.java](https://coveralls.io/builds/29042578/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Frewrite%2Ftoken%2Fgenerator%2Fimpl%2FTableTokenGenerator.java#L67) | 20 | 25 | 80.0%
<!-- | **Total:** | **33** | **38** | **86.84%** | -->
| Totals | [](https://coveralls.io/builds/29042578) |
| :-- | --: |
| Change from base [Build 951](https://coveralls.io/builds/29023442): | 0.007% |
| Covered Lines: | 10608 |
| Relevant Lines: | 17936 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services