You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/02/11 18:11:34 UTC

[GitHub] [arrow] pitrou commented on a change in pull request #9474: ARROW-10420: [C++] Refactor io and filesystem APIs to take an IOContext

pitrou commented on a change in pull request #9474:
URL: https://github.com/apache/arrow/pull/9474#discussion_r574719660



##########
File path: cpp/src/arrow/dataset/file_base.cc
##########
@@ -160,6 +160,13 @@ Status FileWriter::Write(RecordBatchReader* batches) {
   return Status::OK();
 }
 
+Status FileWriter::Finish() {
+  RETURN_NOT_OK(FinishInternal());
+  return destination_->Close();

Review comment:
       Note: explicitly closing output files is preferrable, especially with remote filesystems where this might plausibly fail.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org