[jira] [Commented] (FLINK-18713) Allow default ms unit for table.exec.mini-batch.allow-latency etc.

["Jark Wu (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-18713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165448#comment-17165448 ] 

Jark Wu commented on FLINK-18713:
---------------------------------

Yes. I think we should update them. All of them should be defined as {{ConfigOption<Duration>}} now. The {{ConfigOption}} doesn't support {{Duration}} when we having above options. 

> Allow default ms unit for table.exec.mini-batch.allow-latency etc.
> ------------------------------------------------------------------
>
>                 Key: FLINK-18713
>                 URL: https://issues.apache.org/jira/browse/FLINK-18713
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table SQL / Planner
>    Affects Versions: 1.11.0
>            Reporter: hailong wang
>            Priority: Major
>             Fix For: 1.12.0
>
>
> We use `scala.concurrent.duration.Duration.create` to parse timeStr in `TableConfigUtils#
> getMillisecondFromConfigDuration` for the following properties,
> {code:java}
> table.exec.async-lookup.timeout
> table.exec.source.idle-timeout
> table.exec.mini-batch.allow-latency
> table.exec.emit.early-fire.delay
> table.exec.emit.late-fire.delay{code}
> And it must has the unit.
> I think we can replace it with `TimeUtils.parseDuration(timeStr)` to parse timeStr just like `DescriptorProperties#getOptionalDuration` to has default ms unit and be consistent.
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)