You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Apache Jenkins Server <je...@builds.apache.org> on 2012/12/07 17:08:38 UTC
[JENKINS] Lucene-Solr-Tests-trunk-Java6 - Build # 15668 - Failure
Build: https://builds.apache.org/job/Lucene-Solr-Tests-trunk-Java6/15668/
All tests passed
Build Log:
[...truncated 7377 lines...]
BUILD FAILED
/usr/home/hudson/hudson-slave/workspace/Lucene-Solr-Tests-trunk-Java6/build.xml:88: The following files contain @author tags, tabs or nocommits:
* solr/solrj/src/java/org/apache/solr/common/cloud/CompositeIdRouter.java
Total time: 16 minutes 58 seconds
Build step 'Invoke Ant' marked build as failure
Archiving artifacts
Recording test results
Email was triggered for: Failure
Sending email for trigger: Failure
[JENKINS] Lucene-Solr-Tests-trunk-Java6 - Build # 15673 - Still
Failing
Posted by Apache Jenkins Server <je...@builds.apache.org>.
Build: https://builds.apache.org/job/Lucene-Solr-Tests-trunk-Java6/15673/
All tests passed
Build Log:
[...truncated 7279 lines...]
BUILD FAILED
/usr/home/hudson/hudson-slave/workspace/Lucene-Solr-Tests-trunk-Java6/build.xml:88: The following files contain @author tags, tabs or nocommits:
* solr/solrj/src/java/org/apache/solr/common/cloud/CompositeIdRouter.java
Total time: 16 minutes 51 seconds
Build step 'Invoke Ant' marked build as failure
Archiving artifacts
Recording test results
Email was triggered for: Failure
Sending email for trigger: Failure
[JENKINS] Lucene-Solr-Tests-trunk-Java6 - Build # 15672 - Still
Failing
Posted by Apache Jenkins Server <je...@builds.apache.org>.
Build: https://builds.apache.org/job/Lucene-Solr-Tests-trunk-Java6/15672/
All tests passed
Build Log:
[...truncated 7283 lines...]
BUILD FAILED
/usr/home/hudson/hudson-slave/workspace/Lucene-Solr-Tests-trunk-Java6/build.xml:88: The following files contain @author tags, tabs or nocommits:
* solr/solrj/src/java/org/apache/solr/common/cloud/CompositeIdRouter.java
Total time: 19 minutes 52 seconds
Build step 'Invoke Ant' marked build as failure
Archiving artifacts
Recording test results
Email was triggered for: Failure
Sending email for trigger: Failure
[JENKINS] Lucene-Solr-Tests-trunk-Java6 - Build # 15671 - Still
Failing
Posted by Apache Jenkins Server <je...@builds.apache.org>.
Build: https://builds.apache.org/job/Lucene-Solr-Tests-trunk-Java6/15671/
All tests passed
Build Log:
[...truncated 7283 lines...]
BUILD FAILED
/usr/home/hudson/hudson-slave/workspace/Lucene-Solr-Tests-trunk-Java6/build.xml:88: The following files contain @author tags, tabs or nocommits:
* solr/solrj/src/java/org/apache/solr/common/cloud/CompositeIdRouter.java
Total time: 17 minutes 44 seconds
Build step 'Invoke Ant' marked build as failure
Archiving artifacts
Recording test results
Email was triggered for: Failure
Sending email for trigger: Failure
Re: [JENKINS] Lucene-Solr-Tests-trunk-Java6 - Build # 15670 - Still Failing
Posted by Dawid Weiss <da...@cs.put.poznan.pl>.
>> Thanks Uwe.
Thanks Uwe. I actually planned on reverting that... then went on to
fix something else in my code... then forgot about it and then fell
asleep... I guess too many things at once.
D.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: [JENKINS] Lucene-Solr-Tests-trunk-Java6 - Build # 15670 - Still Failing
Posted by Yonik Seeley <yo...@lucidworks.com>.
On Sat, Dec 8, 2012 at 10:30 AM, Mark Miller <ma...@gmail.com> wrote:
> Just as an update/fyi - I went to do this - then realized it would be easier to like change this check to an assert and put a todo for yonik to look closer at it or something - but saw that Uwe simply removed the nocommit.
>
> So yonik can just take a look when he gets a chance.
>
> Thanks Uwe.
Oops!
The code block Dawid referenced is no longer needed - I'll finish cleaning up.
-Yonik
http://lucidworks.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: [JENKINS] Lucene-Solr-Tests-trunk-Java6 - Build # 15670 - Still Failing
Posted by Mark Miller <ma...@gmail.com>.
Just as an update/fyi - I went to do this - then realized it would be easier to like change this check to an assert and put a todo for yonik to look closer at it or something - but saw that Uwe simply removed the nocommit.
So yonik can just take a look when he gets a chance.
Thanks Uwe.
- Mark
On Dec 8, 2012, at 6:45 AM, Mark Miller <ma...@gmail.com> wrote:
>
> On Dec 7, 2012, at 3:37 PM, Dawid Weiss <da...@cs.put.poznan.pl> wrote:
>
>> I think we should revert to make Jenkins happy; Yonik can re-apply later?
>
> +1 - makes sense to me.
>
> - Mark
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: [JENKINS] Lucene-Solr-Tests-trunk-Java6 - Build # 15670 - Still Failing
Posted by Mark Miller <ma...@gmail.com>.
On Dec 7, 2012, at 3:37 PM, Dawid Weiss <da...@cs.put.poznan.pl> wrote:
> I think we should revert to make Jenkins happy; Yonik can re-apply later?
+1 - makes sense to me.
- Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: [JENKINS] Lucene-Solr-Tests-trunk-Java6 - Build # 15670 - Still Failing
Posted by Mark Miller <ma...@gmail.com>.
Everyone donates their time as they can. I'm glad your donating yours to help look into some test fails!
I've helped look into / fix a lot myself, and I'm as unfamiliar with many Solr areas as you are.
I guess this what happens when you take a bunch of tests for a larger test system that ran pretty well once a day serially and start running them in parallel and all the time on many machines over and over. And then add a bunch of distributed tests running lots of jetty instances, etc.
A lot of the other committers didn't really sign up for that change - we really increased the challenge of writing Solr tests that never fail by like a factor of 20! Since I was part of making this change, I've been trying to help out where I can!
I can see where some Lucene centric people would be like, what the hell, Lucene tests fail less - but I've been in both camps, and the situation is that it's easy to make Lucene tests for this heavy environment, and it's been a lot of work getting Solr tests solid. That's one of the joys of Lucene - no jetty, no dependencies, no heavy application infrastructure. But non the less, the Solr tests have been improving all the time. Special thanks to Dawid and others in helping make that happen!
If you look at some other similar Apache projects that are no libraries and their test code, they would end up being just as difficult to harden to this level.
IMO, it's been worth it though! I can run tests in 4 minutes instead of 40, and all the extra test runs find more bugs. So instead of complaining, I'll just keep pitching in to help when I find time.
- Mark
On Dec 8, 2012, at 7:30 AM, Robert Muir <rc...@gmail.com> wrote:
> My concern is actually that people are just filtering and not looking at test failures.
>
> If thats the case, lets not waste valuable computing resources then. we can do something else with them: such as additional coverage of lucene's test suite.
>
> Otherwise, lets unfilter the fails and instead just fix them. The current situation is very sad:
> I fixed a RAM leak in a solr test earlier this week. The exception in the failure basically told you exactly how to fix it. It was clear to me nobody really even looked at this fail, it was so easy to fix.
> I looked at the J9 bug, honestly i just did basic stuff (not knowing really anything about solr distributed search). like download the JVM, run tests with -Xint, and so on. Its like nobody really cares.
>
> Anyway I guess I'm just frustrated. I'd really like these tests to become stable, and I'd like to help too, but I can barely even help because I don't really know solr. Its going to take more people.
>
>
> On Sat, Dec 8, 2012 at 9:41 AM, Mark Miller <ma...@gmail.com> wrote:
>
> On Dec 8, 2012, at 5:40 AM, Robert Muir <rc...@gmail.com> wrote:
>
> > makes it easier to navigate my gmail by far
>
> If that's your concern, ever hear of a filter :)
>
> - Mark
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: [JENKINS] Lucene-Solr-Tests-trunk-Java6 - Build # 15670 - Still Failing
Posted by Robert Muir <rc...@gmail.com>.
My concern is actually that people are just filtering and not looking at
test failures.
If thats the case, lets not waste valuable computing resources then. we can
do something else with them: such as additional coverage of lucene's test
suite.
Otherwise, lets unfilter the fails and instead just fix them. The current
situation is very sad:
I fixed a RAM leak in a solr test earlier this week. The exception in the
failure basically told you exactly how to fix it. It was clear to me nobody
really even looked at this fail, it was so easy to fix.
I looked at the J9 bug, honestly i just did basic stuff (not knowing really
anything about solr distributed search). like download the JVM, run tests
with -Xint, and so on. Its like nobody really cares.
Anyway I guess I'm just frustrated. I'd really like these tests to become
stable, and I'd like to help too, but I can barely even help because I
don't really know solr. Its going to take more people.
On Sat, Dec 8, 2012 at 9:41 AM, Mark Miller <ma...@gmail.com> wrote:
>
> On Dec 8, 2012, at 5:40 AM, Robert Muir <rc...@gmail.com> wrote:
>
> > makes it easier to navigate my gmail by far
>
> If that's your concern, ever hear of a filter :)
>
> - Mark
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
Re: [JENKINS] Lucene-Solr-Tests-trunk-Java6 - Build # 15670 - Still Failing
Posted by Mark Miller <ma...@gmail.com>.
On Dec 8, 2012, at 5:40 AM, Robert Muir <rc...@gmail.com> wrote:
> makes it easier to navigate my gmail by far
If that's your concern, ever hear of a filter :)
- Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: [JENKINS] Lucene-Solr-Tests-trunk-Java6 - Build # 15670 - Still Failing
Posted by Robert Muir <rc...@gmail.com>.
Are people even looking at build failures?
If not, lets just disable solr tests and reduce the noise again. makes it
easier to navigate my gmail by far
On Fri, Dec 7, 2012 at 6:37 PM, Dawid Weiss <da...@cs.put.poznan.pl>wrote:
> I think Yonik added a nocommit --
>
> Author: Yonik Seeley <yo...@apache.org> 2012-12-07 15:47:34
> Committer: Yonik Seeley <yo...@apache.org> 2012-12-07 15:47:34
>
> ...
> + if (lowerBound > upperBound) {
> + // nocommit
> + throw new RuntimeException("WHAAAT?");
> + }
>
> I think we should revert to make Jenkins happy; Yonik can re-apply later?
>
> Dawid
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
Re: [JENKINS] Lucene-Solr-Tests-trunk-Java6 - Build # 15670 - Still Failing
Posted by Dawid Weiss <da...@cs.put.poznan.pl>.
I think Yonik added a nocommit --
Author: Yonik Seeley <yo...@apache.org> 2012-12-07 15:47:34
Committer: Yonik Seeley <yo...@apache.org> 2012-12-07 15:47:34
...
+ if (lowerBound > upperBound) {
+ // nocommit
+ throw new RuntimeException("WHAAAT?");
+ }
I think we should revert to make Jenkins happy; Yonik can re-apply later?
Dawid
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[JENKINS] Lucene-Solr-Tests-trunk-Java6 - Build # 15670 - Still
Failing
Posted by Apache Jenkins Server <je...@builds.apache.org>.
Build: https://builds.apache.org/job/Lucene-Solr-Tests-trunk-Java6/15670/
All tests passed
Build Log:
[...truncated 7277 lines...]
BUILD FAILED
/usr/home/hudson/hudson-slave/workspace/Lucene-Solr-Tests-trunk-Java6/build.xml:88: The following files contain @author tags, tabs or nocommits:
* solr/solrj/src/java/org/apache/solr/common/cloud/CompositeIdRouter.java
Total time: 16 minutes 46 seconds
Build step 'Invoke Ant' marked build as failure
Archiving artifacts
Recording test results
Email was triggered for: Failure
Sending email for trigger: Failure
[JENKINS] Lucene-Solr-Tests-trunk-Java6 - Build # 15669 - Still
Failing
Posted by Apache Jenkins Server <je...@builds.apache.org>.
Build: https://builds.apache.org/job/Lucene-Solr-Tests-trunk-Java6/15669/
All tests passed
Build Log:
[...truncated 7290 lines...]
BUILD FAILED
/usr/home/hudson/hudson-slave/workspace/Lucene-Solr-Tests-trunk-Java6/build.xml:88: The following files contain @author tags, tabs or nocommits:
* solr/solrj/src/java/org/apache/solr/common/cloud/CompositeIdRouter.java
Total time: 17 minutes 51 seconds
Build step 'Invoke Ant' marked build as failure
Archiving artifacts
Recording test results
Email was triggered for: Failure
Sending email for trigger: Failure