You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2016/08/18 02:45:52 UTC
[kudu-CR] [benchmarks/tpch] added AUTO FLUSH BACKGROUND mode
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4024
Change subject: [benchmarks/tpch] added AUTO_FLUSH_BACKGROUND mode
......................................................................
[benchmarks/tpch] added AUTO_FLUSH_BACKGROUND mode
Added an ability to run KuduSession in AUTO_FLUSH_BACKGROUND mode
while running TPC-H benchmarks. Also did other minor code clean-up
like re-ordering implementation of methods to match their declaration
order, etc.
Change-Id: I69d6897e9d1126270f2dc8b7d913d37e73428c1f
---
M src/kudu/benchmarks/tpch/rpc_line_item_dao.cc
M src/kudu/benchmarks/tpch/rpc_line_item_dao.h
M src/kudu/benchmarks/tpch/tpch-schemas.h
M src/kudu/benchmarks/tpch/tpch1.cc
M src/kudu/benchmarks/tpch/tpch_real_world.cc
5 files changed, 99 insertions(+), 85 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/4024/1
--
To view, visit http://gerrit.cloudera.org:8080/4024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I69d6897e9d1126270f2dc8b7d913d37e73428c1f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [benchmarks/tpch] introduced AUTO FLUSH BACKGROUND mode
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: [benchmarks/tpch] introduced AUTO_FLUSH_BACKGROUND mode
......................................................................
[benchmarks/tpch] introduced AUTO_FLUSH_BACKGROUND mode
Added an ability to run KuduSession in AUTO_FLUSH_BACKGROUND mode
while running TPC-H benchmarks. Also did other minor code clean-up
like re-ordering implementation of methods to match their declaration
order, etc.
Change-Id: I69d6897e9d1126270f2dc8b7d913d37e73428c1f
Reviewed-on: http://gerrit.cloudera.org:8080/4024
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/benchmarks/tpch/rpc_line_item_dao.cc
M src/kudu/benchmarks/tpch/rpc_line_item_dao.h
M src/kudu/benchmarks/tpch/tpch1.cc
M src/kudu/benchmarks/tpch/tpch_real_world.cc
4 files changed, 99 insertions(+), 82 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I69d6897e9d1126270f2dc8b7d913d37e73428c1f
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [benchmarks/tpch] introduced AUTO FLUSH BACKGROUND mode
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [benchmarks/tpch] introduced AUTO_FLUSH_BACKGROUND mode
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4024/2/src/kudu/benchmarks/tpch/rpc_line_item_dao.h
File src/kudu/benchmarks/tpch/rpc_line_item_dao.h:
Line 61: bool IsTableEmpty();
> I might be missing something, but as I see, this method is in use: benchmar
Ah, my bad. I thought you removed the implementation; on second look, I saw that you just moved it. Nevermind.
--
To view, visit http://gerrit.cloudera.org:8080/4024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69d6897e9d1126270f2dc8b7d913d37e73428c1f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [benchmarks/tpch] introduced AUTO FLUSH BACKGROUND mode
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4024
to look at the new patch set (#2).
Change subject: [benchmarks/tpch] introduced AUTO_FLUSH_BACKGROUND mode
......................................................................
[benchmarks/tpch] introduced AUTO_FLUSH_BACKGROUND mode
Added an ability to run KuduSession in AUTO_FLUSH_BACKGROUND mode
while running TPC-H benchmarks. Also did other minor code clean-up
like re-ordering implementation of methods to match their declaration
order, etc.
Change-Id: I69d6897e9d1126270f2dc8b7d913d37e73428c1f
---
M src/kudu/benchmarks/tpch/rpc_line_item_dao.cc
M src/kudu/benchmarks/tpch/rpc_line_item_dao.h
M src/kudu/benchmarks/tpch/tpch1.cc
M src/kudu/benchmarks/tpch/tpch_real_world.cc
4 files changed, 99 insertions(+), 82 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/4024/2
--
To view, visit http://gerrit.cloudera.org:8080/4024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I69d6897e9d1126270f2dc8b7d913d37e73428c1f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [benchmarks/tpch] added AUTO FLUSH BACKGROUND mode
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: [benchmarks/tpch] added AUTO_FLUSH_BACKGROUND mode
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/2971/
--
To view, visit http://gerrit.cloudera.org:8080/4024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69d6897e9d1126270f2dc8b7d913d37e73428c1f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] [benchmarks/tpch] introduced AUTO FLUSH BACKGROUND mode
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [benchmarks/tpch] introduced AUTO_FLUSH_BACKGROUND mode
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4024/2/src/kudu/benchmarks/tpch/rpc_line_item_dao.h
File src/kudu/benchmarks/tpch/rpc_line_item_dao.h:
Line 61: bool IsTableEmpty();
Remove this.
--
To view, visit http://gerrit.cloudera.org:8080/4024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69d6897e9d1126270f2dc8b7d913d37e73428c1f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [benchmarks/tpch] introduced AUTO FLUSH BACKGROUND mode
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: [benchmarks/tpch] introduced AUTO_FLUSH_BACKGROUND mode
......................................................................
Patch Set 2:
Build Started http://104.196.14.100/job/kudu-gerrit/3000/
--
To view, visit http://gerrit.cloudera.org:8080/4024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69d6897e9d1126270f2dc8b7d913d37e73428c1f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [benchmarks/tpch] introduced AUTO FLUSH BACKGROUND mode
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [benchmarks/tpch] introduced AUTO_FLUSH_BACKGROUND mode
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4024/2/src/kudu/benchmarks/tpch/rpc_line_item_dao.h
File src/kudu/benchmarks/tpch/rpc_line_item_dao.h:
Line 61: bool IsTableEmpty();
> Remove this.
I might be missing something, but as I see, this method is in use: benchmarks/tpch/tpch1.cc, line 270.
Do you mean there is some other way to check the table is empty or you are suggesting to remove the method and the corresponding piece of code in tpch1.cc altogether?
I would vote just to add const specifier for the method and keep it.
--
To view, visit http://gerrit.cloudera.org:8080/4024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69d6897e9d1126270f2dc8b7d913d37e73428c1f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes