You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@geaflow.apache.org by "Leomrlin (via GitHub)" <gi...@apache.org> on 2025/09/03 07:20:57 UTC

[PR] [MCP] Implement MCP local tools for demo case [geaflow]

Leomrlin opened a new pull request, #610:
URL: https://github.com/apache/geaflow/pull/610

   ### What changes were proposed in this pull request?
   <!--Please describe the major changes for this PR-->
   
   ### How was this PR tested?
   - [ ] Tests have Added for the changes
   - [ ] Production environment verified
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org
For additional commands, e-mail: issues-help@geaflow.apache.org

Re: [PR] [MCP] Implement MCP local tools for demo case [geaflow]

Posted by "xincai98 (via GitHub)" <gi...@apache.org>.

xincai98 commented on code in PR #610:
URL: https://github.com/apache/geaflow/pull/610#discussion_r2324011314


##########
geaflow-mcp/src/main/java/org/apache/geaflow/mcp/server/GeaFlowMcpActionsLocalImpl.java:
##########
@@ -0,0 +1,208 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.geaflow.mcp.server;
+
+import java.io.File;
+import java.io.IOException;
+import java.nio.charset.Charset;
+import java.time.Instant;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+import java.util.stream.Collectors;
+import org.apache.commons.io.IOUtils;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.geaflow.cluster.local.client.LocalEnvironment;
+import org.apache.geaflow.dsl.common.types.TableField;
+import org.apache.geaflow.dsl.schema.GeaFlowGraph;
+import org.apache.geaflow.dsl.schema.GeaFlowTable;
+import org.apache.geaflow.env.IEnvironment;
+import org.apache.geaflow.mcp.server.util.McpLocalFileUtil;
+import org.apache.geaflow.mcp.server.util.QueryFormatUtil;
+import org.apache.geaflow.mcp.server.util.QueryLocalRunner;
+
+public class GeaFlowMcpActionsLocalImpl implements GeaFlowMcpActions {
+
+    private Map<String, Object> configs;
+    private String user;
+    private IEnvironment localEnv = new LocalEnvironment();
+
+    public GeaFlowMcpActionsLocalImpl(Map<String, Object> configs) {
+        this.configs = configs;
+    }
+
+    @Override
+    public String createGraph(String graphName, String ddl) {
+        QueryLocalRunner runner = new QueryLocalRunner();
+        runner.withGraphName(graphName).withGraphDefine(ddl);
+        GeaFlowGraph graph;
+        try {
+            graph = runner.compileGraph();
+        } catch (Throwable e) {
+            throw new RuntimeException("Compile error: " + e.getCause().getMessage());
+        }
+        if (graph == null) {
+            throw new RuntimeException("Cannot create graph: " + graphName);
+        }
+        //Store graph ddl to schema
+        try {
+            McpLocalFileUtil.createAndWriteFile(
+                    QueryLocalRunner.DSL_STATE_REMOTE_SCHEM_PATH, ddl, graphName);
+        } catch (Throwable e) {
+            return runner.getErrorMsg();
+        }
+        return "Create graph " + graphName + " success.";
+    }
+
+    @Override
+    public String queryGraph(String graphName, String dml) {
+        QueryLocalRunner compileRunner = new QueryLocalRunner();
+        String ddl = null;
+        try {
+            ddl = McpLocalFileUtil.readFile(QueryLocalRunner.DSL_STATE_REMOTE_SCHEM_PATH, graphName);
+        } catch (Throwable e) {
+            throw new RuntimeException("Cannot get graph schema for: " + graphName);
+        }
+        compileRunner.withGraphName(graphName).withGraphDefine(ddl);
+        GeaFlowGraph graph;
+        try {
+            graph = compileRunner.compileGraph();
+        } catch (Throwable e) {
+            throw new RuntimeException("Compile error: " + compileRunner.getErrorMsg());
+        }
+        if (graph == null) {
+            throw new RuntimeException("Cannot create graph: " + graphName);
+        }
+
+        QueryLocalRunner runner = new QueryLocalRunner();
+        runner.withGraphDefine(ddl);
+        String usingGraph = "USE GRAPH " + graphName + ";\n";

Review Comment:
    "USE GRAPH " + graphName + ";\n" has appeared several times, and can be written as a template to format. Same as other pattern.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org
For additional commands, e-mail: issues-help@geaflow.apache.org