[GitHub] [tvm] mengceng15 commented on a diff in pull request #11699: Fix AutoTVM int8 vnni dense task extraction problem

[GitBox <gi...@apache.org>]

mengceng15 commented on code in PR #11699:
URL: https://github.com/apache/tvm/pull/11699#discussion_r896475644


##########
python/tvm/autotvm/task/relay_integration.py:
##########
@@ -130,6 +130,10 @@ def extract_from_multiple_program(mods, params, target, target_host=None, ops=No
             assert isinstance(
                 mod, tvm.IRModule
             ), "only support relay Module or Function to be tuned"
+
+            with target:

Review Comment:
   @elvin-n Thanks for the detailed explanation. I just realize that this change could introduce serious compatibility problems due to the autotvm tuning design.
   
   Initially, I followed @masahi 's method to apply alter op layout before the task extraction. Everything worked well. However, it could be a bit confusing to the user. Seems there is no document or hint mentioning that this workaround should be used. My intention to raise this PR was to clean up the confusion.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org