You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by bm...@apache.org on 2015/06/27 03:09:58 UTC

[2/3] mesos git commit: Removed a TODO that is no longer relevant.

Removed a TODO that is no longer relevant.

Review: https://reviews.apache.org/r/35914


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/fe405cde
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/fe405cde
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/fe405cde

Branch: refs/heads/master
Commit: fe405cde88719b96ed22713fa774cd9639aaed00
Parents: 649b376
Author: Benjamin Mahler <be...@gmail.com>
Authored: Thu Jun 25 23:32:36 2015 -0700
Committer: Benjamin Mahler <be...@gmail.com>
Committed: Fri Jun 26 18:09:26 2015 -0700

----------------------------------------------------------------------
 src/sched/sched.cpp | 4 ----
 1 file changed, 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/fe405cde/src/sched/sched.cpp
----------------------------------------------------------------------
diff --git a/src/sched/sched.cpp b/src/sched/sched.cpp
index bc76c71..a4e35aa 100644
--- a/src/sched/sched.cpp
+++ b/src/sched/sched.cpp
@@ -914,8 +914,6 @@ protected:
       // sends it but the master never receives it (message lost,
       // master failover etc). The correct way for schedulers to deal
       // with this situation is to use 'reconcileTasks()'.
-      // TODO(vinod): Kill this optimization in 0.22.0, to give
-      // frameworks time to implement reconciliation.
       foreach (const TaskInfo& task, tasks) {
         StatusUpdate update;
         update.mutable_framework_id()->MergeFrom(framework.id());
@@ -992,8 +990,6 @@ protected:
 
       // NOTE: Reply to the framework with TASK_LOST messages for each
       // task launch. See details from notes in launchTasks.
-      // TODO(vinod): Kill this optimization in 0.22.0, to give
-      // frameworks time to implement reconciliation.
       foreach (const Offer::Operation& operation, operations) {
         if (operation.type() != Offer::Operation::LAUNCH) {
           continue;